[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2527: [Feature][ST-Engine] Add Job Cancel Feature

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #2527:
URL: https://github.com/apache/incubator-seatunnel/pull/2527#discussion_r956529060


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/operation/source/RequestSplitOperation.java:
##########
@@ -46,10 +48,15 @@ public RequestSplitOperation(TaskLocation taskID, TaskLocation enumeratorTaskID)
     @Override
     public void run() throws Exception {
         SeaTunnelServer server = getService();
-        SourceSplitEnumeratorTask<?> task =
+
+        RetryUtils.retryWithException(() -> {
+            SourceSplitEnumeratorTask<?> task =
                 server.getTaskExecutionService().getExecutionContext(enumeratorTaskID.getTaskGroupID())
-                        .getTaskGroup().getTask(enumeratorTaskID.getTaskID());
-        task.requestSplit(taskID.getTaskID());
+                    .getTaskGroup().getTask(enumeratorTaskID.getTaskID());
+            task.requestSplit(taskID.getTaskID());
+            return null;
+        }, new RetryUtils.RetryMaterial(Constant.OPERATION_RETRY_TIME, true,

Review Comment:
   > What causes a NullPointerException?
   
   Because 
   ```
   SourceSplitEnumeratorTask<?> task =
                   server.getTaskExecutionService().getExecutionContext(enumeratorTaskID.getTaskGroupID())
                       .getTaskGroup().getTask(enumeratorTaskID.getTaskID());
   ```
   
   May return null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org