You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/01/29 09:56:56 UTC
[kudu-CR] wal: Include standard prefix on glog lines
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5827
Change subject: wal: Include standard prefix on glog lines
......................................................................
wal: Include standard prefix on glog lines
Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 46 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/5827/1
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] wal: Include standard prefix on glog lines
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: wal: Include standard prefix on glog lines
......................................................................
Patch Set 4: Code-Review+2
Carrying forward Adar's previous +2
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] wal: Include standard prefix on glog lines
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: wal: Include standard prefix on glog lines
......................................................................
wal: Include standard prefix on glog lines
Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Reviewed-on: http://gerrit.cloudera.org:8080/5827
Tested-by: Mike Percy <mp...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 47 insertions(+), 34 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
[kudu-CR] wal: Include standard prefix on glog lines
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: wal: Include standard prefix on glog lines
......................................................................
Patch Set 4: Verified+1
Overriding Jenkins on flaky ClientTest.TestWriteWithDeadTabletServer
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] wal: Include standard prefix on glog lines
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: wal: Include standard prefix on glog lines
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: No
[kudu-CR] wal: Include standard prefix on glog lines
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5827
to look at the new patch set (#3).
Change subject: wal: Include standard prefix on glog lines
......................................................................
wal: Include standard prefix on glog lines
Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
2 files changed, 47 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/5827/3
--
To view, visit http://gerrit.cloudera.org:8080/5827
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I724e85001beb68adbb806212ea3cb63292d0de56
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot