You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 14:56:56 UTC
[PR] test: cover instance guard, limit clamp and multi-connection projection in ProducerConnectionService [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3402:
URL: https://github.com/apache/rocketmq-dashboard/pull/3402
### Summary
`ProducerConnectionService` normalizes filters and selector limits before delegating to the client provider. The existing tests left the `listProducerGroups` instance guard, sub-minimum limit clamping and null-language projections uncovered.
### Changes
- `listProducerGroups` rejects a missing instance id with `400 instanceId is required`
- A selector limit below 1 is clamped to 1 before delegating
- Connections with null language/version project `null` instead of throwing
- Multiple raw connections are projected independently in order
### Testing
`mvn test -Dtest=ProducerConnectionServiceTest` passes: 11 tests, 0 failures (up from 7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover instance guard, limit clamp and multi-connection projection in ProducerConnectionService [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3402: test: cover instance guard, limit clamp and multi-connection projection in ProducerConnectionService
URL: https://github.com/apache/rocketmq-dashboard/pull/3402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org