[jira] [Commented] (AMBARI-9965) RU - Improve performance for large cluster in StackVersionListener

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350977#comment-14350977 ] 

Hadoop QA commented on AMBARI-9965:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12703115/AMBARI-9965.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The test build failed in ambari-server 

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/1956//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/1956//console

This message is automatically generated.

> RU - Improve performance for large cluster in StackVersionListener
> ------------------------------------------------------------------
>
>                 Key: AMBARI-9965
>                 URL: https://issues.apache.org/jira/browse/AMBARI-9965
>             Project: Ambari
>          Issue Type: Task
>            Reporter: Tom Beerbower
>            Assignee: Tom Beerbower
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-9965.patch
>
>
> On a large cluster, all of the agents will heartbeat during registration at the same time, so the HearbeatHandler has to be fast. Right now, the logic to handle host versions is done as part of StackVersionListener, which uses the AmbariEventPublisher, and acquires a lock.
> *This means that the heartbeats will compete for the same lock in a piece of code that makes a lot of DB calls.*
> Use a separate EventBus since we should not listen for host version changes using AmbariEventPublisher
> We should also move HearbeatHandler.java (around line 520)
> {code}
> HostComponentVersionEvent event = new HostComponentVersionEvent(cl, scHost);
> ambariEventPublisher.publish(event);
> {code}
> inside the handleComponentVersionReceived() method.
> As an optimization, we should consider only registering the event if "previousVersion" differs from the new value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)