[GitHub] [hadoop] functioner commented on pull request #3872: HADOOP-18046. TestIPC#testIOEOnListenerAccept fails

[GitBox <gi...@apache.org>]

functioner commented on pull request #3872:
URL: https://github.com/apache/hadoop/pull/3872#issuecomment-1026504948


   @iwasakims @ayushtkn @steveloughran Thank you for your suggestions.
   
   I inspected this test more carefully and I found that previous I wrote the `testIOEOnListenerAccept` based on `doErrorTest`, which is generally used in the scenario where the fault is about the data type (e.g., `IOEOnWriteWritable` instead of `LongWritable`).
   
   However, the scenario here is more similar to `testRTEDuringConnectionSetup`, `testIpcTimeout`, `testIpcConnectTimeout`, `testIpcWithServiceClass`, etc. I notice that these tests share some style which is slightly different from `doErrorTest`. Specifically, they have `new TestServer(1, true)` and make the client call with `call(client, RANDOM.nextLong(), address, conf)` where `address` is `NetUtils.getConnectAddress(server)`.
   
   I try to enforce this style and it works on my local machine when I run `mvn test -Dtest=TestIPC -Pparallel-tests`. On the contrary, without this modification, `mvn test -Dtest=TestIPC -Pparallel-tests` may fail `testIOEOnListenerAccept` in the way you guys reported.
   
   I push this new commit and would like to see whether it works on our CI servers and see potential new comments.
   @iwasakims @ayushtkn PTAL. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org