You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pdmack <gi...@git.apache.org> on 2014/06/30 22:05:49 UTC
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
GitHub user pdmack opened a pull request:
https://github.com/apache/spark/pull/1271
SPARK-2332 [build] add exclusion for old servlet-api on hadoop-client in core
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pdmack/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1271
----
commit 6f39fecfe8e506f73374412c6999a7641b80df36
Author: Peter MacKinnon <pm...@redhat.com>
Date: 2014-06-30T19:49:42Z
add exclusion for old servlet-api on hadoop-client in core
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47619505
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47625138
Thanks. I'm merging this in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47594705
On a very related note, have a look at https://github.com/apache/spark/pull/906 -- SPARK-1949. It addresses something very similar and I fixed the problem in it vis-a-vis tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47619556
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47579967
I've been wrestling with this dependency for a while. However I thought we specifically wanted to retain servlet-api 3.0. What problem are you seeing? It's possible there's a different answer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47580342
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47580459
Yeah, saw your detail on the JIRA. Yes 2.5 should not be in there, I'm just surprised it is. The concern is knocking out 3.0 accidentally. Have you checked that is all OK still? I'll look too just because I've been staring at this particular dependency hell for a while now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47619566
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47621924
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16278/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47621923
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by pdmack <gi...@git.apache.org>.
Github user pdmack commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47580217
Well, the build seems generally set up for jetty 8 which makes use of servlet-api 3.0.x. So I'm assuming we don't want the old 2.5 one since there are numerous explicit excludes littered through the poms for that version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47594589
Thanks for sending this. Do you mind updating the SBT build file as well (project/SparkBuild.scala)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by pdmack <gi...@git.apache.org>.
Github user pdmack commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47580937
mvn -X -Dhadoop.version=2.0.0-mr1-cdh4.1.2 -Dlabel=centos test
I didn't see any jetty test failures and certainly none of the previous FilterRegistration security exceptions. Also 3.0 remains in tact:
DEBUG] Invalidating /home/pmackinn/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar: class javax.servlet.http.HttpServletRequest now provided by /home/pmackinn/.m2/repository/org/eclipse/jetty/orbit/javax.servlet/3.0.0.v201112011016/javax.servlet-3.0.0.v201112011016.jar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by pdmack <gi...@git.apache.org>.
Github user pdmack commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47610230
@rxin, I added requested change to project/SparkBuild.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2332 [build] add exclusion for old servl...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/1271#issuecomment-47589343
Hey @pdmack as far as I can see, you're correct. javax.servlet:servlet-api is not currently a dependency for most (?) Hadoop versions. It seems to come in with versions of Hadoop 2.0.x via hadoop-hdfs. Excluding it should be fine since it is not desirable where it is brought in, and not brought in elsewhere.
Just check that it all works, that the web UI starts. I have managed to accidentally exclude all copies of the servlet API accidentally before!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---