You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/12 17:46:29 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11670: feat: new import commands for dataset and databases

codecov-io edited a comment on pull request #11670:
URL: https://github.com/apache/incubator-superset/pull/11670#issuecomment-726233683


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=h1) Report
   > Merging [#11670](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=desc) (ba459f6) into [master](https://codecov.io/gh/apache/incubator-superset/commit/45738ffc1dfe94deb6578b6e5b0d6687558969e9?el=desc) (45738ff) will **decrease** coverage by `0.56%`.
   > The diff coverage is `92.82%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11670/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11670      +/-   ##
   ==========================================
   - Coverage   62.25%   61.68%   -0.57%     
   ==========================================
     Files         874      426     -448     
     Lines       42348    26519   -15829     
     Branches     3972        0    -3972     
   ==========================================
   - Hits        26363    16358   -10005     
   + Misses      15805    10161    -5644     
   + Partials      180        0     -180     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `?` | |
   | python | `61.68% <92.82%> (-0.21%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.53% <0.00%> (-0.28%)` | :arrow_down: |
   | [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `75.39% <16.66%> (-2.48%)` | :arrow_down: |
   | [superset/commands/importers/v1.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxLnB5) | `90.32% <90.32%> (ø)` | |
   | [superset/datasets/commands/importers/v1.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxLnB5) | `98.76% <98.76%> (ø)` | |
   | [superset/databases/commands/importers/v1.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS5weQ==) | `100.00% <100.00%> (ø)` | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `88.33% <100.00%> (+0.41%)` | :arrow_up: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.53%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/11670/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=footer). Last update [45738ff...ba459f6](https://codecov.io/gh/apache/incubator-superset/pull/11670?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org