[kudu-CR] tablet: remove tablet_do_dup_key_checks flag

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Hello David Ribeiro Alves, Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3117

to review the following change.

Change subject: tablet: remove tablet_do_dup_key_checks flag
......................................................................

tablet: remove tablet_do_dup_key_checks flag

This flag was never safe to set to anything but 'true', and is a remnant from
some very early (Jan '13) prototyping efforts. Quoting the description of the
original commit (fd7cfd5cfb500eb8330b5787):

    This isn't a sustainable flag, but rather just a stopgap until there
    are bloom filter checks against the different layers. Disabling the
    duplicate key checks speeds up inserts by an order of magnitude. The
    assumption is that bloom filters will have a similar effect, but
    this can be used in the meantime for benchmarking.

Removing it now as it will make sharing code between Insert and Upsert slightly
easier.

Change-Id: I883422aca12065926d98300aeed0493d2a956bfa
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 16 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/3117/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I883422aca12065926d98300aeed0493d2a956bfa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans