You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2023/06/21 00:44:00 UTC
[jira] [Commented] (IMPALA-12202) Switch native-toolchain from lsb_release to /etc/os-release
[ https://issues.apache.org/jira/browse/IMPALA-12202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735492#comment-17735492 ]
Joe McDonnell commented on IMPALA-12202:
----------------------------------------
Addressed in [https://github.com/cloudera/native-toolchain/commit/69999674bc4140c43f05f1a05df2d165b10f67ba] :
{noformat}
commit 69999674bc4140c43f05f1a05df2d165b10f67ba
Author: Joe McDonnell <jo...@cloudera.com>
Date: Wed Jun 7 16:04:02 2023 -0700 IMPALA-12202: Replace lsb_release with /etc/os-release
This switches the code in init.sh to use /etc/os-release
rather than lsb_release. /etc/os-release is available on
all supported Linux distributions, and it provides the
same information. There is a database of /etc/os-release
files at https://github.com/chef/os_release that helps
find the right comparisons.
This does not change existing Docker images to stop
installing lsb_release, because sometimes older
native-toolchain branches build on newer Docker images.
However, it does mean that future OSes added (like Redhat 9
and Ubuntu 22) will not need to provide lsb_release.
To support that use case, this adds the --no-lsb-rlease flag
to assert-dependencies-present.py, which tells it that
lsb_release is not required. Existing images do not specify
that flag, so lsb_release is still verified.
This removes the RELEASE_NAME environment variable and
obsolete code that used it. It also adds an assertion that
the utility 'cmp' is present. This is currently provided
as a transitive dependency of lsb_release, but any new
distribution without lsb_release will need to get it directly.
Testing:
- Built new docker images and ran builds with them
Change-Id: I3aecaf0fddf27e2a8fbff00a772d6a1cdc6fd7eb
Reviewed-on: http://gerrit.cloudera.org:8080/20062
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
{noformat}
> Switch native-toolchain from lsb_release to /etc/os-release
> -----------------------------------------------------------
>
> Key: IMPALA-12202
> URL: https://issues.apache.org/jira/browse/IMPALA-12202
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
>
> native-toolchain uses lsb_release to detect the OS name /version. lsb_release is getting harder to install and is no longer available in the Redhat 9 repositories. We should replace it with /etc/os-release, which provides the same functionality.
> This is the native-toolchain equivalent to Impala's IMPALA-12179.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org