You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/16 07:34:11 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

WeiZhong94 opened a new pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768
 
 
   ## What is the purpose of the change
   
   *This pull request supports set the configuration option "pipeline.jars" in PyFlink, which could be used to add user jars during the job code execution.*
   
   
   ## Brief change log
   
     - *When the "pipeline.jars" is set to the python configuration object, load the jars to context class loader.*
     - *When the PyFlink `TableEnvironment#execute()` method is called, pass the "pipeline.jars" configuration in `TableConfig` to `ExecutionEnviornment#configuration`*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *test_table_environment_api.py*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160507586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160674334) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718616",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01280e72a363ee72180dd385dc95e0013f60650f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160718616) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409515839
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_table_environment_api.py
 ##########
 @@ -329,6 +334,54 @@ def test_table_environment_with_blink_planner(self):
 
         self.assert_equals(results, ['2,hi,hello\n', '3,hello,hello\n'])
 
+    def test_set_jars(self):
+        jar_urls = []
+        func1_class_name = "org.apache.flink.table.planner.plan.stream.sql.Func1"
+        func2_class_name = "org.apache.flink.python.util.TestScalarFunction"
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func1_class_name,
+            "flink-table/flink-table-planner-blink/target/flink-table-planner-blink*-tests.jar"))
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func2_class_name,
+            "flink-python/target/flink-python*-tests.jar"))
+
+        # test set the "pipeline.jars" multiple times
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        first_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
+
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", jar_urls[0])
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        third_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
+
+        self.assertEqual(first_class_loader, third_class_loader)
+
+        source = self.t_env.from_elements([(1, "Hi"), (2, "Hello")], ["a", "b"])
+        self.t_env.register_java_function("func1", func1_class_name)
+        self.t_env.register_java_function("func2", func2_class_name)
+        table_sink = source_sink_utils.TestAppendSink(
+            ["a", "b"], [DataTypes.STRING(), DataTypes.STRING()])
+        self.t_env.register_table_sink("sink", table_sink)
+        source.select("func1(a.cast(int), b), func2(a.cast(int), b)").insert_into("sink")
+        self.t_env.execute("test")
+        actual = source_sink_utils.results()
+        expected = ['1 and Hi,1 or Hi', '2 and Hello,2 or Hello']
+        self.assert_equals(actual, expected)
+
+    def validate_and_return_unloaded_jar_url(self, func_class_name, jar_filename_pattern):
 
 Review comment:
   Split it into two methods to make it more clear?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409503068
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_table_environment_api.py
 ##########
 @@ -329,6 +334,54 @@ def test_table_environment_with_blink_planner(self):
 
         self.assert_equals(results, ['2,hi,hello\n', '3,hello,hello\n'])
 
+    def test_set_jars(self):
+        jar_urls = []
+        func1_class_name = "org.apache.flink.table.planner.plan.stream.sql.Func1"
+        func2_class_name = "org.apache.flink.python.util.TestScalarFunction"
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func1_class_name,
+            "flink-table/flink-table-planner-blink/target/flink-table-planner-blink*-tests.jar"))
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func2_class_name,
+            "flink-python/target/flink-python*-tests.jar"))
+
+        # test set the "pipeline.jars" multiple times
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        first_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
+
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", jar_urls[0])
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        third_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
 
 Review comment:
   third_class_loader -> second_class_loader

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718616",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01280e72a363ee72180dd385dc95e0013f60650f Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160718616) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409517022
 
 

 ##########
 File path: tools/travis_controller.sh
 ##########
 @@ -148,6 +148,8 @@ if [ $STAGE == "$STAGE_COMPILE" ]; then
             ! -path "$CACHE_FLINK_DIR/flink-dist/target/flink-*-bin/flink-*/opt/flink-python*.jar" \
             ! -path "$CACHE_FLINK_DIR/flink-connectors/flink-connector-elasticsearch-base/target/flink-*.jar" \
             ! -path "$CACHE_FLINK_DIR/flink-connectors/flink-connector-kafka-base/target/flink-*.jar" \
+            ! -path "$CACHE_FLINK_DIR/flink-python/target/flink-python*-tests.jar" \
 
 Review comment:
   What about generating two jars for this test purpose instead of reusing the existing test jars? It would be small and also could avoid potential problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160507586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573) 
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160674334) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] WeiZhong94 commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-615041372
 
 
   @kl0u Hi Kostas, the change of `LocalExecutor` has been included in this PR. It seems all tests are passed. Please take a look. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409515490
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_table_environment_api.py
 ##########
 @@ -329,6 +334,54 @@ def test_table_environment_with_blink_planner(self):
 
         self.assert_equals(results, ['2,hi,hello\n', '3,hello,hello\n'])
 
+    def test_set_jars(self):
+        jar_urls = []
+        func1_class_name = "org.apache.flink.table.planner.plan.stream.sql.Func1"
+        func2_class_name = "org.apache.flink.python.util.TestScalarFunction"
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func1_class_name,
+            "flink-table/flink-table-planner-blink/target/flink-table-planner-blink*-tests.jar"))
+        jar_urls.extend(self.validate_and_return_unloaded_jar_url(
+            func2_class_name,
+            "flink-python/target/flink-python*-tests.jar"))
+
+        # test set the "pipeline.jars" multiple times
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        first_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
+
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", jar_urls[0])
+        self.t_env.get_config().get_configuration().set_string("pipeline.jars", ";".join(jar_urls))
+        third_class_loader = get_gateway().jvm.Thread.currentThread().getContextClassLoader()
+
+        self.assertEqual(first_class_loader, third_class_loader)
+
+        source = self.t_env.from_elements([(1, "Hi"), (2, "Hello")], ["a", "b"])
+        self.t_env.register_java_function("func1", func1_class_name)
+        self.t_env.register_java_function("func2", func2_class_name)
+        table_sink = source_sink_utils.TestAppendSink(
+            ["a", "b"], [DataTypes.STRING(), DataTypes.STRING()])
+        self.t_env.register_table_sink("sink", table_sink)
+        source.select("func1(a.cast(int), b), func2(a.cast(int), b)").insert_into("sink")
+        self.t_env.execute("test")
+        actual = source_sink_utils.results()
+        expected = ['1 and Hi,1 or Hi', '2 and Hello,2 or Hello']
+        self.assert_equals(actual, expected)
+
+    def validate_and_return_unloaded_jar_url(self, func_class_name, jar_filename_pattern):
+        test_jars = glob.glob(os.path.join(_find_flink_source_root(), jar_filename_pattern))
+        if not test_jars:
+            self.fail("'%s' is not available. Please compile the test jars first."
+                      % jar_filename_pattern)
+        try:
+            self.t_env.register_java_function("func", func_class_name)
+        except Py4JJavaError:
+            pass
+        else:
+            self.fail("The scalar function '%s' should not been loaded before this test case. "
 
 Review comment:
   Change the error message to `The scalar function '%s' should not be able to be loaded. ` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160674334) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160507586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573) 
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160674334) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624) 
   * 01280e72a363ee72180dd385dc95e0013f60650f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160674334",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624",
       "triggerID" : "b796de76daa408c58f6aa13391c93f1a1e88bb57",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160718616",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657",
       "triggerID" : "01280e72a363ee72180dd385dc95e0013f60650f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b796de76daa408c58f6aa13391c93f1a1e88bb57 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160674334) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7624) 
   * 01280e72a363ee72180dd385dc95e0013f60650f Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160718616) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7657) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] WeiZhong94 commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-615039935
 
 
   @dianfu Thanks for your review! I have addressed your comments in the latest commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160507586) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409496472
 
 

 ##########
 File path: flink-python/pyflink/table/table_environment.py
 ##########
 @@ -1095,6 +1096,19 @@ def _set_python_executable_for_local_executor(self):
                 and is_local_deployment(j_config):
             j_config.setString(jvm.PythonOptions.PYTHON_EXECUTABLE.key(), sys.executable)
 
+    def _write_pipeline_jars_to_j_env(self):
 
 Review comment:
   Rename to _add_pipeline_jars_to_j_env_config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#discussion_r409497954
 
 

 ##########
 File path: flink-python/pyflink/util/utils.py
 ##########
 @@ -98,3 +98,30 @@ def is_local_deployment(j_configuration):
     JDeploymentOptions = jvm.org.apache.flink.configuration.DeploymentOptions
     return j_configuration.containsKey(JDeploymentOptions.TARGET.key()) \
         and j_configuration.getString(JDeploymentOptions.TARGET.key(), None) == "local"
+
+
+def add_jars_to_context_class_loader(jar_urls):
+    """
+    Add jars to Python gateway server for local compilation and local execution (i.e. minicluster).
+    There are many component in Flink which won't be added to classpath by default. e.g. Kafka
+    connector, JDBC connector, CSV format etc. This utility function can be used to hot load the
+    jars.
+
+    :param jar_urls: The list of jar urls.
+    """
+    gateway = get_gateway()
+    # validate and normalize
+    jar_urls = [gateway.jvm.java.net.URL(url).toString() for url in jar_urls]
+    context_classloader = gateway.jvm.Thread.currentThread().getContextClassLoader()
+    existed_urls = []
 
 Review comment:
   existing_urls

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614470724
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 (Thu Apr 16 07:37:51 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16943).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614482552
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/160507586",
       "triggerID" : "a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a3aa6b6cab6c0a7e0e26c0cf3ef0e38f265e8799 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160507586) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7573) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11768: [FLINK-16943][python] Support set the configuration option "pipeline.jars" in PyFlink.
URL: https://github.com/apache/flink/pull/11768#issuecomment-614663047
 
 
   We should also update the documentation about this. Otherwise, there is no way users could be aware of it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services