About Snapshot Operation on KVM

[Star Guo <st...@ceph.me>]

Hello,

I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM + Ceph/RBD 0.80.8.
I deploy an instance on RBD and I create the ROOT volume snapshots. When
delete a snapshot the UI show OK, but the snapshot of the volume in the RBD
pool is still exist.
And I find the code in
com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: 
.
    @Override
    public Answer deleteSnapshot(DeleteCommand cmd) {
        return new Answer(cmd);
    }
.
deleteSnapshot() does not be implememented. And I also find the code:
...
    @Override
    public Answer createTemplateFromSnapshot(CopyCommand cmd) {
        return null;  //To change body of implemented methods use File |
Settings | File Templates.
    }
...
So does createTenokateFromSnapshot(). I just look for it in MASTER branch
but not do that yet. Will CloudStack Dev Team plan to do that ? Thanks for
reply .

Best Regards,
Star Guo

Re: About Snapshot Operation on KVM

[Wido den Hollander <wi...@widodh.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 03/05/2015 01:33 PM, Star Guo wrote:
> Hello,
> 
> I just build a lab with CloudStack 4.4.2 + CentOS 6.6 KVM +
> Ceph/RBD 0.80.8. I deploy an instance on RBD and I create the ROOT
> volume snapshots. When delete a snapshot the UI show OK, but the
> snapshot of the volume in the RBD pool is still exist. And I find
> the code in 
> com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java: . 
> @Override public Answer deleteSnapshot(DeleteCommand cmd) { return
> new Answer(cmd); } . deleteSnapshot() does not be implememented.
> And I also find the code: ... @Override public Answer
> createTemplateFromSnapshot(CopyCommand cmd) { return null;  //To
> change body of implemented methods use File | Settings | File
> Templates. } ... So does createTenokateFromSnapshot(). I just look
> for it in MASTER branch but not do that yet. Will CloudStack Dev
> Team plan to do that ? Thanks for reply .

Hmm, I haven't looked at that yet.

Could you open a Jira issue for this? I'll probably won't be able to
work on this any time soon, but this should be fixed.

Wido

> 
> Best Regards, Star Guo
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJU+FISAAoJEAGbWC3bPspCvI8QALGY9T46JS3BDyCNtzWJcYDW
FUisB2b6BNbxDm+TGbZahgR3RosQYFV4OYuL4U2WR2mg07YLrPZVlR6EnCEQnJXA
k0GY6kOBAxnfiLKHaRvTw8vriI69KN27tiyxtXR7/iCPcQjAAh5jxSWupM2AnmZX
20z6nYFmmMj4My13fF1dQgWPUreUX7cG5eOrybqhy0jxcCZ1Z6Z9gDIS1B6YEndT
acTfUNAEytJBthruAITl878Rf47Uypooq8H5ySgB+fsJSOF3HpgX8ZdjRyv9EEH9
07VDDLn99gX8FLrA7IKwun2Y4GozVmlNCxJMJkTjDUeDaMRKCrAmsRHrJpYzltiT
H2R4HILFIiSyFukPQTFddL0aJ3QJRz6zRnS0x8WIp6LFkAbwIZCz0vh6ciikeSZF
Rebtahoq6YifQ1u+TTnPyWa/r7DBcuCXULa2ECqtSsXO+cmgUVzr/36K8JcF8RVC
NviZ/yyAsyJ7h+U4T0f4YzJFcBJQ7ho4YrZJ8qKIknYq8WdQCFSg4fYckHfbhxjF
P6ZhDZIBGHYD3zj+pwC7fWHgLmRUe7Xg8bJwMbC1rbe1/MVKuS7ULPiEnlV8866y
lljFrBHefDz5nAV5ukBOquZXaM7ENxJ5cMV8SO4oetcO1761evhSjv2lNSSEJ1C6
pxFxBZRSe+tvgLbskmCx
=7tTx
-----END PGP SIGNATURE-----