You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by zhangh43 <gi...@git.apache.org> on 2016/08/25 07:32:25 UTC
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
GitHub user zhangh43 opened a pull request:
https://github.com/apache/incubator-hawq/pull/861
HAWQ-1001. Implement HAWQ user ACL check through Ranger.
Along with HAWQ-1002. Implement a switch in hawq-site.xml to configure whether use Ranger or not for ACL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangh43/incubator-hawq ranger
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #861
----
commit 6e1f7f8b2a93e38e206ddfca4bec30820097a3f3
Author: hzhang2 <zh...@163.com>
Date: 2016-08-18T09:08:58Z
HAWQ-1002. Implement a switch in hawq-site.xml to configure whether use Ranger or not for ACL.
commit 7f1245477b80f3f1cf86947eb1401f57ac8f2938
Author: hzhang2 <zh...@163.com>
Date: 2016-08-25T03:06:43Z
HAWQ-1001. Implement HAWQ user ACL check through Ranger.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r76368047
--- Diff: src/backend/utils/misc/guc.c ---
@@ -4323,6 +4324,16 @@ static struct config_bool ConfigureNamesBool[] =
},
{
+ {"enable_ranger", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
+ gettext_noop("support to using ranger to manage hawq privilege."),
--- End diff --
Enable Apache Ranger for HAWQ privilege management.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r76209911
--- Diff: src/backend/utils/misc/guc.c ---
@@ -4323,6 +4324,16 @@ static struct config_bool ConfigureNamesBool[] =
},
{
+ {"enable_ranger", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
+ gettext_noop("support to using ranger to manage hawq privilege."),
--- End diff --
s/using/use/
s/ranger/Apache Ranger/ ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r77746304
--- Diff: src/backend/catalog/aclchk.c ---
@@ -225,10 +225,18 @@ restrict_and_check_grant(bool is_grant, AclMode avail_goptions, bool all_privs,
*/
if (avail_goptions == ACL_NO_RIGHTS)
{
- if (pg_aclmask(objkind, objectId, grantorId,
- whole_mask | ACL_GRANT_OPTION_FOR(whole_mask),
- ACLMASK_ANY) == ACL_NO_RIGHTS)
- aclcheck_error(ACLCHECK_NO_PRIV, objkind, objname);
+ if (enable_ranger) {
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #861: HAWQ-1001. Implement HAWQ user ACL check through ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/861
Whether need a test case for this code change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r76209892
--- Diff: src/backend/utils/misc/guc.c ---
@@ -349,6 +349,7 @@ bool Debug_datumstream_write_use_small_initial_buffers = false;
bool gp_temporary_files_filespace_repair = false;
bool filesystem_support_truncate = true;
bool gp_allow_non_uniform_partitioning_ddl = true;
+bool enable_ranger = false;
--- End diff --
ident
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/861
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r77746338
--- Diff: src/backend/utils/misc/guc.c ---
@@ -4323,6 +4324,16 @@ static struct config_bool ConfigureNamesBool[] =
},
{
+ {"enable_ranger", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
+ gettext_noop("support to using ranger to manage hawq privilege."),
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #861: HAWQ-1001. Implement HAWQ user ACL check t...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/861#discussion_r77746358
--- Diff: src/backend/utils/misc/guc.c ---
@@ -349,6 +349,7 @@ bool Debug_datumstream_write_use_small_initial_buffers = false;
bool gp_temporary_files_filespace_repair = false;
bool filesystem_support_truncate = true;
bool gp_allow_non_uniform_partitioning_ddl = true;
+bool enable_ranger = false;
--- End diff --
fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---