You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/15 17:57:20 UTC
[GitHub] [airflow] jplauri opened a new pull request #19599: Misc. documentation typos and language improvements
jplauri opened a new pull request #19599:
URL: https://github.com/apache/airflow/pull/19599
Related: https://github.com/apache/airflow/issues/19581
Simply put, this PR fixes some typos and improves the English at a few places (see the commit).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19599: Misc. documentation typos and language improvements
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19599:
URL: https://github.com/apache/airflow/pull/19599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19599: Misc. documentation typos and language improvements
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19599:
URL: https://github.com/apache/airflow/pull/19599#issuecomment-971833221
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19599: Misc. documentation typos and language improvements
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19599:
URL: https://github.com/apache/airflow/pull/19599#issuecomment-969926117
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19599: Misc. documentation typos and language improvements
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19599:
URL: https://github.com/apache/airflow/pull/19599#discussion_r749591174
##########
File path: airflow/providers/google/cloud/hooks/workflows.py
##########
@@ -212,7 +212,7 @@ def list_workflows(
:param filter_: Filter to restrict results to specific workflows.
:type filter_: str
- :param order_by: Comma-separated list of fields that that
+ :param order_by: Comma-separated list of fields that
specify the order of the results. Default sorting order for a field is ascending.
Review comment:
```suggestion
specifies the order of the results. Default sorting order for a field is ascending.
```
While we’re at this…
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19599: Misc. documentation typos and language improvements
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19599:
URL: https://github.com/apache/airflow/pull/19599#discussion_r749591564
##########
File path: airflow/providers/google/cloud/operators/workflows.py
##########
@@ -299,7 +299,7 @@ class WorkflowsListWorkflowsOperator(BaseOperator):
:param filter_: Filter to restrict results to specific workflows.
:type filter_: str
- :param order_by: Comma-separated list of fields that that
+ :param order_by: Comma-separated list of fields that
specify the order of the results. Default sorting order for a field is ascending.
Review comment:
```suggestion
specifies the order of the results. Default sorting order for a field is ascending.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org