[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

["Will-Lo (via GitHub)" <gi...@apache.org>]

Will-Lo commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1122276405


##########
gradle/scripts/globalDependencies.gradle:
##########
@@ -57,6 +57,7 @@ subprojects {
         }
       }
       all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
+      all*.exclude group: 'org.mockito', module: 'mockito-all'

Review Comment:
   Can we leave a comment why we need to make this exclusion?



##########
gobblin-aws/src/test/java/org/apache/gobblin/aws/GobblinAWSClusterLauncherTest.java:
##########
@@ -64,6 +44,19 @@
 import org.apache.gobblin.cluster.TestHelper;
 import org.apache.gobblin.cluster.TestShutdownMessageHandlerFactory;
 import org.apache.gobblin.testing.AssertWithBackoff;
+import org.apache.helix.HelixManager;
+import org.apache.helix.HelixManagerFactory;
+import org.apache.helix.InstanceType;
+import org.apache.helix.model.Message;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;

Review Comment:
   Can we follow the import order on the style guide?
   https://gobblin.apache.org/docs/developer-guide/CodingStyle/
   There's an intellij file you can set as the guide and intellij can autoformat the imports for you.
   On a side note I should look into trying to enforce this as part of checkstyle but that'll come later<sup>tm</sup>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org