You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by johnmccabe <gi...@git.apache.org> on 2016/04/04 18:42:43 UTC

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

GitHub user johnmccabe opened a pull request:

    https://github.com/apache/brooklyn-dist/pull/30

    lower minimum Vagrant version to 1.7.0

    - verified locally on OSX myself and via @neykov

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnmccabe/brooklyn-dist loosen-vagrant-version-reqs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-dist/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 2a28d4c375021819a818ad3655ac07689e3c781e
Author: John McCabe <jo...@johnmccabe.net>
Date:   2016-04-04T16:05:53Z

    lower minimum Vagrant version to 1.7.0
    - verified locally on OSX myself and via @neykov

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205387427
  
    fyi @neykov @richardcloudsoft 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205747371
  
    @neykov thats very odd, I ran with 1.7.0 locally  (wiped Vagrant and installed the old version)...
    
    Are you running on OSX/Windows or Linux?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205387372
  
    Following discussion on dev list [here](http://mail-archives.apache.org/mod_mbox/incubator-brooklyn-dev/201604.mbox/%3C9DB9EFC3-48FA-45BA-8CFC-C92D9242EE11%40cloudsoftcorp.com%3E)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe closed the pull request at:

    https://github.com/apache/brooklyn-dist/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209400171
  
    `1.8.0` won't work unless all env keys & values are strings, see this comment https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205778386



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205753420
  
    I tested on Ubuntu 14.04. Btw by default it install `1.4.3` :).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209399633
  
    @neykov is there anything else I need to do before we merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209410323
  
    Closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209406371
  
    Works for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205778386
  
    Getting the following error when testing with `1.8.0`
    ```
    ==> brooklyn: Destroying VM and associated drives...
    /opt/vagrant/embedded/gems/gems/vagrant-1.8.0/plugins/provisioners/shell/provisioner.rb:162:in `quote_and_escape': undefined method `gsub' for false:FalseClass (NoMethodError)
    	from /opt/vagrant/embedded/gems/gems/vagrant-1.8.0/plugins/provisioners/shell/provisioner.rb:50:in `block in provision_ssh'
    	from /opt/vagrant/embedded/gems/gems/vagrant-1.8.0/plugins/provisioners/shell/provisioner.rb:50:in `each'
    	from /opt/vagrant/embedded/gems/gems/vagrant-1.8.0/plugins/provisioners/shell/provisioner.rb:50:in `map'
    	from /opt/vagrant/embedded/gems/gems/vagrant-1.8.0/plugins/provisioners/shell/provisioner.rb:50:in `provision_ssh'
    ```
    
    Related to https://github.com/mitchellh/vagrant/issues/6707. Needed to convert the `false` in the env section to a string by quoting it.
    
    Also updating the packages takes forever, adding the following to `Vagrantfile` speeds it up considerably.
    ```
    	vb.customize ["modifyvm", :id, "--nictype1", "virtio"]
    	vb.customize ["modifyvm", :id, "--nictype2", "virtio"]
    ```
    
    Still waiting for the `up` to complete, will report with the result.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205744736
  
    Tested with vagrant `1.7.0`. It's failing with `The following settings shouldn't exist: env`. Seems this was introduced in 1.8.0. So either need to move away from using env or bump the version to `1.8.0`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.7.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205750915
  
    Hmm, looks like my 1.8.1 hadn't been blown away, was in `/usr/local/bin/vagrant` rather than the `/usr/bin/vagrant` that the Vagrant docs on uninstallation refer to..
    
    Regarding getting rid of env, I'd don't think we should do that to cater to users running obsolete versions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209404907
  
    Feels like a bad move to hack around a fixed bug in `1.8.0` that has been addressed in `1.8.1` - tempted to close the PR and leave as-is here but add a comment to the getting started steps. wdyt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-209401424
  
    Ah ok, missed that, I'll ping you when I submit a fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205862979
  
    Fixed the binding problem in https://github.com/apache/brooklyn-server/pull/101, affects only master branch (0.10.x versions)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205784061
  
    @neykov Ubuntu 14.04 again?
    
    Interesting tweak to the nics!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205763246
  
    We'd only been targeting OSX and Windows


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-dist pull request: lower minimum Vagrant version to 1.8.0

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:

    https://github.com/apache/brooklyn-dist/pull/30#issuecomment-205791607
  
    Testing on OS X now. Turns out that virtualbox can't run inside another VM. Other than that the host shouldn't make a difference.
    
    Removing the failing `vagrant-catalog.bom` allowed me to start brooklyn. It's listening on `127.0.0.1:8081` only. Can't connect to it on the `10.10.10.x` network. The port is not mapped on the NAT interface as well (no `forwarded_ports` section inside the yaml).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---