You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Артём Луканин <ic...@mail.ru> on 2014/03/13 12:30:13 UTC
waitFlush is not used in SolrServer.commit()
Hello,
I'm trying to understand how to use commit( boolean waitFlush, boolean waitSearcher, boolean softCommit )
It appears, that AbstractUpdateRequest.setAction is called, which doesn't use waitFlush at all.
Can we remove waitFlush not to confuse the users?
Artem
Re[4]: waitFlush is not used in SolrServer.commit()
Posted by Артём Луканин <ic...@mail.ru>.
Great! +1
Четверг, 13 марта 2014, 10:38 -07:00 от Mark Miller <ma...@gmail.com>:
>https://issues.apache.org/jira/browse/SOLR-2018
>--
>Mark Miller
>about.me/markrmiller
>On March 13, 2014 at 5:42:57 AM, Артём Луканин ( ice_lc@mail.ru ) wrote:
>>Yes, that would be more understandable. Should I make a JIRA ticket
for this?
>>>The wiki says: “ In Solr4.0 it
will be removed. ”
>>>
>>>See:
>>>https://wiki.apache.org/solr/UpdateXmlMessages
>>>
>>>Unfortunately, the new Solr Reference Guide does not include
that note.
>>>
>>>See:
>>>https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
>>>
>>>I would be +1 for having Solr give a 400 error for using it. I
mean, the app is expecting some specific behavior, and that
behavior is not going to happen.
>>>
>>>-- Jack Krupansky
>>>
>>>From: Артём Луканин
>>>Sent: Thursday, March 13, 2014 7:30 AM
>>>To: dev@lucene.apache.org
>>>Subject: waitFlush is not used in
SolrServer.commit()
>>>
>>>Hello,
>>>
>>>I'm trying to understand how to use commit( boolean waitFlush,
boolean waitSearcher, boolean softCommit )
>>>It appears, that AbstractUpdateRequest.setAction is called, which
doesn't use waitFlush at all.
>>>
>>>Can we remove waitFlush not to confuse the users?
>>>
>>>Artem
Re: Re[2]: waitFlush is not used in SolrServer.commit()
Posted by Mark Miller <ma...@gmail.com>.
https://issues.apache.org/jira/browse/SOLR-2018
--
Mark Miller
about.me/markrmiller
On March 13, 2014 at 5:42:57 AM, Артём Луканин (ice_lc@mail.ru) wrote:
Yes, that would be more understandable. Should I make a JIRA ticket for this?
The wiki says: “ In Solr4.0 it will be removed.”
See:
https://wiki.apache.org/solr/UpdateXmlMessages
Unfortunately, the new Solr Reference Guide does not include that note.
See:
https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
I would be +1 for having Solr give a 400 error for using it. I mean, the app is expecting some specific behavior, and that behavior is not going to happen.
-- Jack Krupansky
From: Артём Луканин
Sent: Thursday, March 13, 2014 7:30 AM
To: dev@lucene.apache.org
Subject: waitFlush is not used in SolrServer.commit()
Hello,
I'm trying to understand how to use commit( boolean waitFlush, boolean waitSearcher, boolean softCommit )
It appears, that AbstractUpdateRequest.setAction is called, which doesn't use waitFlush at all.
Can we remove waitFlush not to confuse the users?
Artem
Re[2]: waitFlush is not used in SolrServer.commit()
Posted by Артём Луканин <ic...@mail.ru>.
Yes, that would be more understandable. Should I make a JIRA ticket for this?
>The wiki says: “ In Solr4.0 it will be removed. ”
>
>See:
>https://wiki.apache.org/solr/UpdateXmlMessages
>
>Unfortunately, the new Solr Reference Guide does not include that
note.
>
>See:
>https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
>
>I would be +1 for having Solr give a 400 error for using it. I mean, the
app is expecting some specific behavior, and that behavior is not going to
happen.
>
>-- Jack
Krupansky
>
>From: Артём Луканин
>Sent: Thursday, March 13, 2014 7:30 AM
>To: dev@lucene.apache.org
>Subject: waitFlush is not used in
SolrServer.commit()
>
>Hello,
>
>I'm
trying to understand how to use commit( boolean waitFlush, boolean waitSearcher,
boolean softCommit )
>It appears, that AbstractUpdateRequest.setAction is
called, which doesn't use waitFlush at all.
>
>Can we remove waitFlush not
to confuse the users?
>
>Artem
Re[2]: waitFlush is not used in SolrServer.commit()
Posted by Артём Луканин <ic...@mail.ru>.
Yes, I tried to add new setActionParams methods, but we then have to add new methods in SolrServer as well? commit(waitFlush...) and optimize(waitFlush...) are used in a lot of places... But I think, the only possible way is to introduce new method names, because users can use old signatures with the new releases of Solr and get unexpected results.
setUpdateAction is a confusing name, I think.
Четверг, 13 марта 2014, 23:46 -06:00 от Shawn Heisey <so...@elyograg.org>:
>On 3/13/2014 10:18 PM, Артём Луканин wrote:
>> Yes, I was thinking about deprecating the old methods as well.
>> I'll try to add a patch
>> here: https://issues.apache.org/jira/browse/SOLR-2018
>
>I started working on a patch to deprecate old commit methods, but
>further digging has revealed that all varieties of
>AbstractUpdateRequest#setAction have waitFlush as well, and that none of
>them actually *use* the parameter.
>
>Because of the way the method signatures in Java work, it won't be
>possible to just remove a boolean from the various setAction methods and
>deprecate the old versions ... it will need to be replaced with a whole
>new name.
>
>If it's an acceptable path, I can deprecate all of the setAction methods
>and create a series of setUpdateAction methods to replace them. What do
>the senior committers think about this?
>
>SOLR-2018 seems to have been filed with the idea of actually figuring
>out how to properly implement waitFlush. Mark Miller took ownership of
>the issue earlier today ... are we implementing or fully ripping out?
>
>Thanks,
>Shawn
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>For additional commands, e-mail: dev-help@lucene.apache.org
>
Re: waitFlush is not used in SolrServer.commit()
Posted by Shawn Heisey <so...@elyograg.org>.
On 3/13/2014 10:18 PM, Артём Луканин wrote:
> Yes, I was thinking about deprecating the old methods as well.
> I'll try to add a patch
> here: https://issues.apache.org/jira/browse/SOLR-2018
I started working on a patch to deprecate old commit methods, but
further digging has revealed that all varieties of
AbstractUpdateRequest#setAction have waitFlush as well, and that none of
them actually *use* the parameter.
Because of the way the method signatures in Java work, it won't be
possible to just remove a boolean from the various setAction methods and
deprecate the old versions ... it will need to be replaced with a whole
new name.
If it's an acceptable path, I can deprecate all of the setAction methods
and create a series of setUpdateAction methods to replace them. What do
the senior committers think about this?
SOLR-2018 seems to have been filed with the idea of actually figuring
out how to properly implement waitFlush. Mark Miller took ownership of
the issue earlier today ... are we implementing or fully ripping out?
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re[2]: waitFlush is not used in SolrServer.commit()
Posted by Артём Луканин <ic...@mail.ru>.
Yes, I was thinking about deprecating the old methods as well.
I'll try to add a patch here: https://issues.apache.org/jira/browse/SOLR-2018
Четверг, 13 марта 2014, 12:34 -06:00 от Shawn Heisey <so...@elyograg.org>:
>On 3/13/2014 6:17 AM, Jack Krupansky wrote:
>> The wiki says: “In Solr4.0it will be removed.”
>> See:
>> https://wiki.apache.org/solr/UpdateXmlMessages
>> Unfortunately, the new Solr Reference Guide does not include that note.
>> See:
>> https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
>> I would be +1 for having Solr give a 400 error for using it. I mean,
>> the app is expecting some specific behavior, and that behavior is not
>> going to happen.
>
>Solr 4.x *DOES* return an error if you use waitFlush with commit. It
>broke the php solr package with Solr 4.0 back in 2012. They fixed their
>bug a couple of weeks ago:
>
>https://bugs.php.net/bug.php?id=62332
>
>SolrJ still has the parameter in two of the SolrServer#commit methods,
>but it is ignored and not sent to Solr. Changing these APIs in 4.x
>would break a *LOT* of user software.
>
>I have thought of a way forward with SolrJ's commit methods:
>
>* Add commit(boolean waitSearcher), softCommit(), and softCommit(boolean
>waitSearcher).
>* Deprecate the existing commit methods with two and three booleans.
>Remove them in 5.0.
>
>Thanks,
>Shawn
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>For additional commands, e-mail: dev-help@lucene.apache.org
>
Re: waitFlush is not used in SolrServer.commit()
Posted by Shawn Heisey <so...@elyograg.org>.
On 3/13/2014 6:17 AM, Jack Krupansky wrote:
> The wiki says: “In Solr4.0it will be removed.”
> See:
> https://wiki.apache.org/solr/UpdateXmlMessages
> Unfortunately, the new Solr Reference Guide does not include that note.
> See:
> https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
> I would be +1 for having Solr give a 400 error for using it. I mean,
> the app is expecting some specific behavior, and that behavior is not
> going to happen.
Solr 4.x *DOES* return an error if you use waitFlush with commit. It
broke the php solr package with Solr 4.0 back in 2012. They fixed their
bug a couple of weeks ago:
https://bugs.php.net/bug.php?id=62332
SolrJ still has the parameter in two of the SolrServer#commit methods,
but it is ignored and not sent to Solr. Changing these APIs in 4.x
would break a *LOT* of user software.
I have thought of a way forward with SolrJ's commit methods:
* Add commit(boolean waitSearcher), softCommit(), and softCommit(boolean
waitSearcher).
* Deprecate the existing commit methods with two and three booleans.
Remove them in 5.0.
Thanks,
Shawn
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: waitFlush is not used in SolrServer.commit()
Posted by Jack Krupansky <ja...@basetechnology.com>.
The wiki says: “ In Solr4.0 it will be removed.”
See:
https://wiki.apache.org/solr/UpdateXmlMessages
Unfortunately, the new Solr Reference Guide does not include that note.
See:
https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers
I would be +1 for having Solr give a 400 error for using it. I mean, the app is expecting some specific behavior, and that behavior is not going to happen.
-- Jack Krupansky
From: Артём Луканин
Sent: Thursday, March 13, 2014 7:30 AM
To: dev@lucene.apache.org
Subject: waitFlush is not used in SolrServer.commit()
Hello,
I'm trying to understand how to use commit( boolean waitFlush, boolean waitSearcher, boolean softCommit )
It appears, that AbstractUpdateRequest.setAction is called, which doesn't use waitFlush at all.
Can we remove waitFlush not to confuse the users?
Artem