You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 23:34:00 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15889: [BEAM-13187] Set filesToStage after local path has been resolved

TheNeuralBit commented on a change in pull request #15889:
URL: https://github.com/apache/beam/pull/15889#discussion_r742424001



##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -670,7 +670,8 @@ def __enter__(self):
       self._service_provider = subprocess_server.JavaJarServer(
           ExpansionAndArtifactRetrievalStub,
           self._path_to_jar,
-          self._extra_args)
+          self._extra_args + [f'--filesToStage={self._path_to_jar}'],

Review comment:
       The behavior is a little different here. We set `--filesToStage` even if extra_args was not None in `__init__`. I'm not sure if the previous behavior was intentional or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org