You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/10/23 15:22:04 UTC

Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/
-----------------------------------------------------------

Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.


Diffs
-----

  tools/marvin/marvin/marvinPlugin.py aded17c 

Diff: https://reviews.apache.org/r/14874/diff/


Testing
-------


Thanks,

Santhosh Edukulla


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/#review28510
-----------------------------------------------------------


4.2: ae852adabb70f43d6d349dd4ab56dc3116e10aed

- Girish Shilamkar


On Oct. 23, 2013, 1:53 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14874/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/marvinPlugin.py aded17c 
> 
> Diff: https://reviews.apache.org/r/14874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Girish Shilamkar <gi...@clogeny.com>.
Sebastien,

I thought only a few patches did not make it to 4.2. I will go over the list do the needful

Regards,
Girish

On 01-Nov-2013, at 1:13 PM, Sebastien Goasguen <ru...@gmail.com> wrote:

> Girish,
> 
> You can review all of Santosh patches on review board:
> https://reviews.apache.org/users/santhoshe/
> 
> Right now it seems that everything has been reviewed, so Santosh will need to submit his patches through review board and assign you as reviewer.
> 
> Hope that helps,
> 
> -sebastien
> 
> 
> On Nov 1, 2013, at 3:37 AM, Girish Shilamkar <gi...@clogeny.com> wrote:
> 
>> Santhosh,
>> 
>> I believe there are more such patches which need to go into 4.2 branch. Could you please send me the list, so that I can push them ?
>> Thanks !
>> 
>> Regards,
>> Girish
>> 
>> On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla <sa...@citrix.com> wrote:
>> 
>>> yes, even few other changes we did around marvin,should also go to 4.2 i believe.
>>> 
>>> Santhosh
>>> ________________________________________
>>> From: Girish Shilamkar [noreply@reviews.apache.org] on behalf of Girish Shilamkar [girish@clogeny.com]
>>> Sent: Friday, November 01, 2013 3:07 AM
>>> To: Prasanna Santhanam
>>> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
>>> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console
>>> 
>>> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/
>>> 
>>> 
>>> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
>>> 
>>> 0780604 master
>>> 
>>> Shouldn't this fix also go to 4.2 branch ?
>>> 
>>> 
>>> - Girish
>>> 
>>> 
>>> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
>>> 
>>> Review request for cloudstack and Prasanna Santhanam.
>>> By Santhosh Edukulla.
>>> 
>>> Updated Oct. 23, 2013, 1:53 p.m.
>>> 
>>> Repository: cloudstack-git
>>> Description
>>> 
>>> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
>>> 
>>> 
>>> Diffs
>>> 
>>> *   tools/marvin/marvin/marvinPlugin.py (aded17c)
>>> 
>>> View Diff<https://reviews.apache.org/r/14874/diff/>
>>> 
>>> 
>> 
> 


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Sebastien Goasguen <ru...@gmail.com>.
Girish,

You can review all of Santosh patches on review board:
https://reviews.apache.org/users/santhoshe/

Right now it seems that everything has been reviewed, so Santosh will need to submit his patches through review board and assign you as reviewer.

Hope that helps,

-sebastien


On Nov 1, 2013, at 3:37 AM, Girish Shilamkar <gi...@clogeny.com> wrote:

> Santhosh,
> 
> I believe there are more such patches which need to go into 4.2 branch. Could you please send me the list, so that I can push them ?
> Thanks !
> 
> Regards,
> Girish
> 
> On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla <sa...@citrix.com> wrote:
> 
>> yes, even few other changes we did around marvin,should also go to 4.2 i believe.
>> 
>> Santhosh
>> ________________________________________
>> From: Girish Shilamkar [noreply@reviews.apache.org] on behalf of Girish Shilamkar [girish@clogeny.com]
>> Sent: Friday, November 01, 2013 3:07 AM
>> To: Prasanna Santhanam
>> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
>> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console
>> 
>> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/
>> 
>> 
>> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
>> 
>> 0780604 master
>> 
>> Shouldn't this fix also go to 4.2 branch ?
>> 
>> 
>> - Girish
>> 
>> 
>> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
>> 
>> Review request for cloudstack and Prasanna Santhanam.
>> By Santhosh Edukulla.
>> 
>> Updated Oct. 23, 2013, 1:53 p.m.
>> 
>> Repository: cloudstack-git
>> Description
>> 
>> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
>> 
>> 
>> Diffs
>> 
>> *   tools/marvin/marvin/marvinPlugin.py (aded17c)
>> 
>> View Diff<https://reviews.apache.org/r/14874/diff/>
>> 
>> 
> 


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Girish Shilamkar <gi...@clogeny.com>.
Santhosh,

I believe there are more such patches which need to go into 4.2 branch. Could you please send me the list, so that I can push them ?
Thanks !

Regards,
Girish

On 01-Nov-2013, at 12:58 PM, Santhosh Edukulla <sa...@citrix.com> wrote:

> yes, even few other changes we did around marvin,should also go to 4.2 i believe.
> 
> Santhosh
> ________________________________________
> From: Girish Shilamkar [noreply@reviews.apache.org] on behalf of Girish Shilamkar [girish@clogeny.com]
> Sent: Friday, November 01, 2013 3:07 AM
> To: Prasanna Santhanam
> Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
> Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console
> 
> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/
> 
> 
> On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:
> 
> 0780604 master
> 
> Shouldn't this fix also go to 4.2 branch ?
> 
> 
> - Girish
> 
> 
> On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:
> 
> Review request for cloudstack and Prasanna Santhanam.
> By Santhosh Edukulla.
> 
> Updated Oct. 23, 2013, 1:53 p.m.
> 
> Repository: cloudstack-git
> Description
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
> 
> 
> Diffs
> 
>  *   tools/marvin/marvin/marvinPlugin.py (aded17c)
> 
> View Diff<https://reviews.apache.org/r/14874/diff/>
> 
> 


RE: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Santhosh Edukulla <sa...@citrix.com>.
yes, even few other changes we did around marvin,should also go to 4.2 i believe.

Santhosh
________________________________________
From: Girish Shilamkar [noreply@reviews.apache.org] on behalf of Girish Shilamkar [girish@clogeny.com]
Sent: Friday, November 01, 2013 3:07 AM
To: Prasanna Santhanam
Cc: Santhosh Edukulla; cloudstack; Girish Shilamkar
Subject: Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14874/


On October 24th, 2013, 9:24 a.m. UTC, Prasanna Santhanam wrote:

0780604 master

Shouldn't this fix also go to 4.2 branch ?


- Girish


On October 23rd, 2013, 1:53 p.m. UTC, Santhosh Edukulla wrote:

Review request for cloudstack and Prasanna Santhanam.
By Santhosh Edukulla.

Updated Oct. 23, 2013, 1:53 p.m.

Repository: cloudstack-git
Description

Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.


Diffs

  *   tools/marvin/marvin/marvinPlugin.py (aded17c)

View Diff<https://reviews.apache.org/r/14874/diff/>



Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Girish Shilamkar <gi...@clogeny.com>.

> On Oct. 24, 2013, 9:24 a.m., Prasanna Santhanam wrote:
> > 0780604 master

Shouldn't this fix also go to 4.2 branch ?


- Girish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/#review27453
-----------------------------------------------------------


On Oct. 23, 2013, 1:53 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14874/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/marvinPlugin.py aded17c 
> 
> Diff: https://reviews.apache.org/r/14874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/#review27453
-----------------------------------------------------------

Ship it!


0780604 master

- Prasanna Santhanam


On Oct. 23, 2013, 1:53 p.m., Santhosh Edukulla wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14874/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/marvinPlugin.py aded17c 
> 
> Diff: https://reviews.apache.org/r/14874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 1:53 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.


Diffs
-----

  tools/marvin/marvin/marvinPlugin.py aded17c 

Diff: https://reviews.apache.org/r/14874/diff/


Testing
-------


Thanks,

Santhosh Edukulla


Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 1:22 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

Adding fix for the bug 4885. This will  add timestamp and timetaken in seconds for a given testcase run.


Diffs
-----

  tools/marvin/marvin/marvinPlugin.py aded17c 

Diff: https://reviews.apache.org/r/14874/diff/


Testing
-------


Thanks,

Santhosh Edukulla