You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2024/10/26 16:47:21 UTC

[PR] Add cmake build script for math library [nuttx-apps]

xiaoxiang781216 opened a new pull request, #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774

   ## Summary
   
   - fix: git status/git status --ignore normalization check problem 
   - cmake:add kissfft CMake build
   - cmake:add gemmlowp CMake build
   - cmake:add ruy CMake build
   
   ## Impact
   
   new cmake file
   
   ## Testing
   
   ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add cmake build script for math library [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774#discussion_r1817968857


##########
math/gemmlowp/CMakeLists.txt:
##########
@@ -0,0 +1,46 @@
+# ##############################################################################
+# apps/math/gemmlowp/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_GEMMLOWP)
+
+  # ############################################################################
+  # Config and Fetch gemmlowp lib
+  # ############################################################################
+
+  set(GEMMLOWP_DIR ${CMAKE_CURRENT_LIST_DIR}/gemmlowp)
+
+  if(NOT EXISTS ${GEMMLOWP_DIR})
+    set(GEMMLOWP_URL
+        https://github.com/google/gemmlowp/archive/719139ce755a0f31cbf1c37f7f98adcc7fc9f425.zip

Review Comment:
   we just test with this commit id, so its better to use the fix id until other people try the different version.



##########
math/ruy/CMakeLists.txt:
##########
@@ -0,0 +1,60 @@
+# ##############################################################################
+# apps/math/ruy/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_RUY)
+
+  # ############################################################################
+  # Config and Fetch ruy lib
+  # ############################################################################
+
+  set(RUY_DIR ${CMAKE_CURRENT_LIST_DIR}/ruy)
+
+  if(NOT EXISTS ${RUY_DIR})
+    set(RUY_URL
+        https://github.com/google/ruy/archive/d37128311b445e758136b8602d1bbd2a755e115d.zip

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add cmake build script for math library [nuttx-apps]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774#discussion_r1817968944


##########
math/kissfft/CMakeLists.txt:
##########
@@ -0,0 +1,74 @@
+# ##############################################################################
+# apps/math/kissfft/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_KISSFFT)
+
+  # ############################################################################
+  # Config and Fetch kissfft lib
+  # ############################################################################
+
+  set(KISSFFT_DIR ${CMAKE_CURRENT_LIST_DIR}/kissfft)
+
+  if(NOT EXISTS ${KISSFFT_DIR})
+    set(KISSFFT_URL
+        https://github.com/mborgerding/kissfft/archive/refs/tags/v130.zip)

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add cmake build script for math library [nuttx-apps]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774#issuecomment-2439655693

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   **No, this PR does not meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Summary:** 
       * Lacks a clear explanation of the problem being fixed. What is the "git status/git status --ignore normalization check problem"?
       * Needs more details on how the CMake builds for kissfft, gemmlowp, and ruy are implemented and their purpose within NuttX.
   * **Impact:**
       *  While it mentions a new CMake file, it doesn't elaborate on the impact. 
       *  All other impact categories are left blank, indicating a lack of consideration for potential consequences.
   * **Testing:**
       * Simply stating "ci" is insufficient. 
       * Provide specific details about the build hosts, target architectures/boards, and the actual testing logs before and after the change.
   
   **Recommendations:**
   
   1. **Expand the Summary:** Clearly articulate the issue being addressed and the implementation details of the CMake additions.
   2. **Complete the Impact Section:** Address all impact categories, even if the answer is "NO" with a brief justification.
   3. **Provide Detailed Testing Information:** List the build hosts, target environments, and include the actual testing logs before and after applying your changes. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add cmake build script for math library [nuttx-apps]

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774#discussion_r1817929555


##########
math/kissfft/CMakeLists.txt:
##########
@@ -0,0 +1,74 @@
+# ##############################################################################
+# apps/math/kissfft/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_KISSFFT)
+
+  # ############################################################################
+  # Config and Fetch kissfft lib
+  # ############################################################################
+
+  set(KISSFFT_DIR ${CMAKE_CURRENT_LIST_DIR}/kissfft)
+
+  if(NOT EXISTS ${KISSFFT_DIR})
+    set(KISSFFT_URL
+        https://github.com/mborgerding/kissfft/archive/refs/tags/v130.zip)

Review Comment:
   Should version be exposed as configuration?



##########
math/ruy/CMakeLists.txt:
##########
@@ -0,0 +1,60 @@
+# ##############################################################################
+# apps/math/ruy/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_RUY)
+
+  # ############################################################################
+  # Config and Fetch ruy lib
+  # ############################################################################
+
+  set(RUY_DIR ${CMAKE_CURRENT_LIST_DIR}/ruy)
+
+  if(NOT EXISTS ${RUY_DIR})
+    set(RUY_URL
+        https://github.com/google/ruy/archive/d37128311b445e758136b8602d1bbd2a755e115d.zip

Review Comment:
   same



##########
math/gemmlowp/CMakeLists.txt:
##########
@@ -0,0 +1,46 @@
+# ##############################################################################
+# apps/math/gemmlowp/CMakeLists.txt
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements.  See the NOTICE file distributed with this work for
+# additional information regarding copyright ownership.  The ASF licenses this
+# file to you under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License.  You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+#
+# ##############################################################################
+
+if(CONFIG_MATH_GEMMLOWP)
+
+  # ############################################################################
+  # Config and Fetch gemmlowp lib
+  # ############################################################################
+
+  set(GEMMLOWP_DIR ${CMAKE_CURRENT_LIST_DIR}/gemmlowp)
+
+  if(NOT EXISTS ${GEMMLOWP_DIR})
+    set(GEMMLOWP_URL
+        https://github.com/google/gemmlowp/archive/719139ce755a0f31cbf1c37f7f98adcc7fc9f425.zip

Review Comment:
   Do we need to expose hash commit as a config option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add cmake build script for math library [nuttx-apps]

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI merged PR #2774:
URL: https://github.com/apache/nuttx-apps/pull/2774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org