You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/09/12 03:19:39 UTC

[GitHub] carbondata pull request #2706: [CARBONDATA-2927] multiple issue fixes for va...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2706#discussion_r216884374
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java ---
    @@ -200,7 +200,7 @@ public static MemoryBlock allocateMemoryWithRetry(long taskId, long size)
         }
         if (baseBlock == null) {
           INSTANCE.printCurrentMemoryUsage();
    -      throw new MemoryException("Not enough memory");
    +      throw new MemoryException("Not enough memory, increase carbon.unsafe.working.memory.in.mb");
    --- End diff --
    
    I think you can optimize the error message to 
    `Not enough unsafe working memory (total: , available: , request: )`


---