You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by "R.B. Boyer" <ar...@nexusvector.net> on 2015/12/17 19:39:17 UTC
Review Request 41525: Add flag to set FrameworkInfo.principal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Bugs closed: AURORA-687
Copying the intent from one of the trailing comments:
"""
There are several situations to consider:
1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
3. existing installs that have authN (may want to add authZ later)
The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
"""
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
Diff: https://reviews.apache.org/r/41525/diff/
Testing
-------
Ran normal unit tests.
Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
Thanks,
R.B. Boyer
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111005
-----------------------------------------------------------
Ship it!
Master (c912c34) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 17, 2015, 6:39 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 6:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111063
-----------------------------------------------------------
Ship it!
lgtm pending the changes Bill requested.
- Joshua Cohen
On Dec. 17, 2015, 6:39 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 6:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 17, 2015, 2:08 p.m., Bill Farner wrote:
> > Sorry for the hassle - we had a few patches just land that caused a merge conflict on NEWS. I tried to step in post the rebased patch. Despite the fact that i can post a patch, ReviewBoard doesn't give me the UI to hit publish. Can you check that you're okay with the latest draft and hit publish?
Huzzah! Never mind, i figured out how to publish my draft from the command line. Hope you don't mind the ghost writing :-)
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111074
-----------------------------------------------------------
On Dec. 17, 2015, 2:34 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:34 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> NEWS 066925e1adc5be825cd44956b497bb9ac017c969
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111074
-----------------------------------------------------------
Sorry for the hassle - we had a few patches just land that caused a merge conflict on NEWS. I tried to step in post the rebased patch. Despite the fact that i can post a patch, ReviewBoard doesn't give me the UI to hit publish. Can you check that you're okay with the latest draft and hit publish?
- Bill Farner
On Dec. 17, 2015, 1:48 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 1:48 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by "R.B. Boyer" <ar...@nexusvector.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 2:34 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Bugs closed: AURORA-687
Copying the intent from one of the trailing comments:
"""
There are several situations to consider:
1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
3. existing installs that have authN (may want to add authZ later)
The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
"""
Diffs (updated)
-----
NEWS 066925e1adc5be825cd44956b497bb9ac017c969
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
Diff: https://reviews.apache.org/r/41525/diff/
Testing
-------
Ran normal unit tests.
Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
Thanks,
R.B. Boyer
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by "R.B. Boyer" <ar...@nexusvector.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 3:48 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Strike type witnesses.
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Bugs closed: AURORA-687
Copying the intent from one of the trailing comments:
"""
There are several situations to consider:
1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
3. existing installs that have authN (may want to add authZ later)
The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
"""
Diffs (updated)
-----
NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
Diff: https://reviews.apache.org/r/41525/diff/
Testing
-------
Ran normal unit tests.
Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
Thanks,
R.B. Boyer
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111066
-----------------------------------------------------------
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java (line 73)
<https://reviews.apache.org/r/41525/#comment171047>
FYI since JDK8 the type witness should be unnecessary, so this can be `Optional.absent()`.
Ditto below.
- Bill Farner
On Dec. 17, 2015, 1:26 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 1:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by "R.B. Boyer" <ar...@nexusvector.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 3:26 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Amend NEWS
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Bugs closed: AURORA-687
Copying the intent from one of the trailing comments:
"""
There are several situations to consider:
1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
3. existing installs that have authN (may want to add authZ later)
The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
"""
Diffs (updated)
-----
NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
Diff: https://reviews.apache.org/r/41525/diff/
Testing
-------
Ran normal unit tests.
Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
Thanks,
R.B. Boyer
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by "R.B. Boyer" <ar...@nexusvector.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 3:24 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Switching to Optional<String> for the principal
Bugs: AURORA-687
https://issues.apache.org/jira/browse/AURORA-687
Repository: aurora
Description
-------
Bugs closed: AURORA-687
Copying the intent from one of the trailing comments:
"""
There are several situations to consider:
1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
3. existing installs that have authN (may want to add authZ later)
The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
"""
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
Diff: https://reviews.apache.org/r/41525/diff/
Testing
-------
Ran normal unit tests.
Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
Thanks,
R.B. Boyer
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 17, 2015, 12:53 p.m., Bill Farner wrote:
> > Thanks, overall this looks great!
> >
> > Can you also add a line in the NEWS file to call out the new flag? Doesn't need formal documentation, just a brief blurb is fine.
>
> R.B. Boyer wrote:
> Under 0.11.0 or in an unspecified area above that?
0.11.0 please!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111043
-----------------------------------------------------------
On Dec. 17, 2015, 10:39 a.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 10:39 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by "R.B. Boyer" <ar...@nexusvector.net>.
> On Dec. 17, 2015, 2:53 p.m., Bill Farner wrote:
> > Thanks, overall this looks great!
> >
> > Can you also add a line in the NEWS file to call out the new flag? Doesn't need formal documentation, just a brief blurb is fine.
Under 0.11.0 or in an unspecified area above that?
- R.B.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111043
-----------------------------------------------------------
On Dec. 17, 2015, 12:39 p.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 12:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>
Re: Review Request 41525: Add flag to set FrameworkInfo.principal
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41525/#review111043
-----------------------------------------------------------
Thanks, overall this looks great!
Can you also add a line in the NEWS file to call out the new flag? Doesn't need formal documentation, just a brief blurb is fine.
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java (line 137)
<https://reviews.apache.org/r/41525/#comment171037>
How about `Optional<String>` and a branch to avoid the call to `setPrinciPal` when it's absent? I'm not sure how an empty string is handled on the other end, but it seems safest to omit the field and match current behavior.
- Bill Farner
On Dec. 17, 2015, 10:39 a.m., R.B. Boyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41525/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 10:39 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Bugs closed: AURORA-687
>
> Copying the intent from one of the trailing comments:
>
> """
> There are several situations to consider:
>
> 1. fresh installs that will not have authN/authZ (may want to add authN/authZ later)
> 2. fresh installs that will begin life with authN/authZ (no problems in the future unless the principal is changed)
> 3. existing installs that have authN (may want to add authZ later)
>
> The current defaults are friendly for (1) above, where the typical test-driver won't be turning any flavor of Auth on in their mesos cluster. These defaults are good.
>
> If someone elects to go down (2) above, the defaults you get from -framework_authentication_file are not awesome, as this is where the misstep lies.
>
> If someone went down (3) above already, and used the -framework_authentication_file non-awesome setting, you also don't want _them_ to break their cluster.
>
> The bare minimum change to be the least breaking would be to introduce a new setting like -framework_announce_principal or something so that (2) can be happy without breaking (3).
>
> Similarly to the mesos checkpoint breaking change, you could roll this out as opt-in and then in a future release make it opt-out when setting -framework_authentication_file and announce it as a breaking change in the changelogs for the poor folks in group (3).
> """
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 68aeda1692271841d10e5f29d439806576bd691c
> src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java 513391ff82c3e985bf9f673d35414e9245807b4a
>
> Diff: https://reviews.apache.org/r/41525/diff/
>
>
> Testing
> -------
>
> Ran normal unit tests.
>
> Built the patched scheduler and deployed it in an authN+authZ mesos cluster (3 control plane boxes, 2 execution plane boxes) and the framework could actually register with mesos.
>
>
> Thanks,
>
> R.B. Boyer
>
>