You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:51:45 UTC
[GitHub] [couchdb] big-r81 opened a new pull request, #4342: Remove Spidermonkey 1.8.5
big-r81 opened a new pull request, #4342:
URL: https://github.com/apache/couchdb/pull/4342
Removes the old Spidermonkey 1.8.5 source code.
Spidermonkey 91 is set as the new default version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
janl merged PR #4342:
URL: https://github.com/apache/couchdb/pull/4342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
big-r81 commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062370470
##########
configure.ps1:
##########
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
No, I only adapted this to the *nix configure-[version](https://github.com/apache/couchdb/blob/33ee2164e6e73429193bc353a2c7dfb9d27a7790/configure#L261)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
janl commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062486124
##########
configure.ps1:
##########
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
ok, but this also has nothing to do with SM91? It’d be good to keep topical things in separate commits/PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
big-r81 commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062506843
##########
configure.ps1:
##########
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
ok, fixed. Should the doc update be separate too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #4342: Remove Spidermonkey 1.8.5
Posted by GitBox <gi...@apache.org>.
janl commented on PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1371172172
let’s not remove support just yet. +1 for moving the default foward tho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
janl commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062353502
##########
configure.ps1:
##########
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
stray commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
big-r81 commented on PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1371360376
Okay, setting only the default sm version to 91 and reverted the remove of 1.8.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4342: Set Spidermonkey 91 as default
Posted by GitBox <gi...@apache.org>.
big-r81 commented on PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1374050147
@janl separated all non sm91-default changes to standalone PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org