Re: Review Request 68565: Fixed SLRP compilation with Clang 3.5.

[Chun-Hung Hsiao <ch...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68565/#review211793
-----------------------------------------------------------


Ship it!




- Chun-Hung Hsiao


On Aug. 30, 2018, 5:09 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68565/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2018, 5:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-9193
>     https://issues.apache.org/jira/browse/MESOS-9193
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clang 3.5 incorrectly keeps const qualifiers when inferring the return
> types of lambdas if their return expressions are const-qualified. This
> patch makes the return types explicit to avoid this issue when compiling
> SLRP and its tests.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200 
>   src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed 
> 
> 
> Diff: https://reviews.apache.org/r/68565/diff/2/
> 
> 
> Testing
> -------
> 
> make check with clang 3.5.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>