You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/03 02:34:16 UTC

[GitHub] jinhuang415 commented on a change in pull request #10783: Fix 'make clean USE_MKLDNN=1' will build mkldnn issue

jinhuang415 commented on a change in pull request #10783: Fix 'make clean USE_MKLDNN=1' will build mkldnn issue
URL: https://github.com/apache/incubator-mxnet/pull/10783#discussion_r185687263
 
 

 ##########
 File path: Makefile
 ##########
 @@ -66,13 +66,22 @@ $(warning "USE_MKL2017 is deprecated. We will switch to USE_MKLDNN.")
 endif
 
 ifeq ($(USE_MKLDNN), 1)
+ifeq ($(MAKECMDGOALS),)
 
 Review comment:
   MAKECMDGOALS is a makefile builtin variable used to indicate the make target, if user input "make clean", MAKECMDGOALS will be 'clean', if user input "make all", MAKECMDGOALS  will be 'all', and default will be empty (we usually don't specify the target when make MXNet so MAKECMDGOALS will be empty and Makefile will find first target which is all to build).
   So user don't need to set MAKECMDGOALS, it is set automatically by make.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services