You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by runyontr <gi...@git.apache.org> on 2016/02/27 03:56:03 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
GitHub user runyontr opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/752
ZEPPELIN-198 HDFS File Interpreter
### What is this PR for?
This pull request is a follow of https://github.com/apache/incubator-zeppelin/pull/276 started by @raj-bains. The additional commits address comments from the pull request regarding string creation and error propagation for bad object requests.
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Feature/Subtask
### Todos
### Is there a relevant Jira issue?
[ZEPPELIN-198](https://issues.apache.org/jira/browse/ZEPPELIN-198)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/runyontr/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit 865e6ab5970d79613f19a0afadb0c953efc2730b
Author: Raj Bains <ra...@rajs-macbook-pro.local>
Date: 2015-09-03T06:50:56Z
Add File Interpreter, HDFS Interpreter and Tests
commit 7d61e5fb6ecb278f99fbec1af72fe983366e6a5a
Author: Raj Bains <ra...@rajs-macbook-pro.local>
Date: 2015-09-05T04:29:59Z
This is the first reviewed version of File Interpreter that adds basic ls, cd and pwd functionality against WebHDFS. It addresses ZEPPELIN-198
commit 1239fe6b8114b6bd2b3af070d7f61610510b65af
Author: Raj Bains <ra...@rajs-macbook-pro.local>
Date: 2015-09-10T17:46:59Z
Merge remote-tracking branch 'upstream/master'
Merge with master so that the documentation can be checked-in using single commit
commit 70507a84b16463bbd94b749129d849204fdd36f9
Author: Raj Bains <ra...@rajs-macbook-pro.local>
Date: 2015-09-10T19:10:41Z
Add Documentation and a missing dependency for HDFS File Browser
commit 79f0d905b48beb5ac86a7b02e4aefc3273cc18a5
Author: Tom Runyon <ru...@gmail.com>
Date: 2016-02-26T01:05:19Z
Merge branch 'master' of http://github.com/raj-bains/incubator-zeppelin
commit 27e04384eb007a8372ecf6d6eb68ac420dde5d58
Author: Tom Runyon <ru...@gmail.com>
Date: 2016-02-26T03:20:04Z
Modified string creation to use StringBuilder
commit 797fd29dad7906ccd7f2b7591c80745812d9e649
Author: Tom Runyon <ru...@gmail.com>
Date: 2016-02-26T03:22:18Z
Added org.glassfish.jersey.core to pom.xml file for hdfs intepretor
commit 32ed7cb3a6d47068f40781e49c466db356f342a2
Author: Tom Runyon <ru...@gmail.com>
Date: 2016-02-27T02:18:16Z
ZEPPELIN-198 Added -h flag for human readable byte sizes. Updated string creation to StringBuilder.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/752#issuecomment-193553923
It's more recommended to merge current master to solve conflict. That'll run additional CI test before merge it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/752#issuecomment-196969970
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/752#issuecomment-194643497
I have tested and working well. Thanks for the contribution!
I left few more comments. And you also probably want to add `zeppelin-distribution/src/bin_license/NOTICE` to [ZeppelinConfiguration.java](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L440) and [conf/zeppelin-site.xml.template](https://github.com/apache/incubator-zeppelin/blob/master/conf/zeppelin-site.xml.template#L141).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by runyontr <gi...@git.apache.org>.
Github user runyontr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/752#issuecomment-193548418
Thank you all for the comments. I've noticed that now there is a note for this pull request that this branch has conflicts that must be resolved. Would you like me to re-merge in the current master branch from apache/incubator-zeppelin, or will the approver of the pull request deal with the merge conflicts that have come up from pulling new branches into master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-198 HDFS File Interprete...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/752#issuecomment-197467198
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---