You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by yl...@apache.org on 2017/01/05 11:39:58 UTC

svn commit: r1777453 - /httpd/httpd/branches/2.2.x/STATUS

Author: ylavic
Date: Thu Jan  5 11:39:58 2017
New Revision: 1777453

URL: http://svn.apache.org/viewvc?rev=1777453&view=rev
Log:
Promote r1753592 as showstopper, since it also fixes build with MSVC.
(Not worth fixing the build if we can backport this change, two fixes for the price of one :)

Modified:
    httpd/httpd/branches/2.2.x/STATUS

Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1777453&r1=1777452&r2=1777453&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Thu Jan  5 11:39:58 2017
@@ -102,6 +102,16 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
+  *) mod_proxy: Correctly consider error response codes by the backend when
+     processing failonstatus. PR 59869
+      Trunk version of patch:
+         http://svn.apache.org/r1753592
+      Backport version for 2.4.x of patch:
+         http://svn.apache.org/r1756562
+      Backport version for 2.2.x of patch:
+         http://home.apache.org/~ylavic/patches/httpd-2.2.x-r1753592.patch
+      +1: ylavic
+
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 
@@ -140,16 +150,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      2.2.x patch: trunk works (modulo CHANGES)
      +1: ylavic
 
-  *) mod_proxy: Correctly consider error response codes by the backend when
-     processing failonstatus. PR 59869
-      Trunk version of patch:
-         http://svn.apache.org/r1753592
-      Backport version for 2.4.x of patch:
-         http://svn.apache.org/r1756562
-      Backport version for 2.2.x of patch:
-         http://home.apache.org/~ylavic/patches/httpd-2.2.x-r1753592.patch
-      +1: ylavic
-
   *) mod_ssl: Support compilation against libssl built with OPENSSL_NO_SSL3
      [but without: and change the compiled-in default for SSL[Proxy]Protocol
                    to "all -SSLv3", in accordance with RFC 7568]



Re: svn commit: r1777453 - /httpd/httpd/branches/2.2.x/STATUS

Posted by William A Rowe Jr <wr...@rowe-clan.net>.
On Fri, Jan 6, 2017 at 6:51 PM, Yann Ylavic <yl...@gmail.com> wrote:
> On Thu, Jan 5, 2017 at 12:39 PM,  <yl...@apache.org> wrote:
>> Author: ylavic
>> Date: Thu Jan  5 11:39:58 2017
>> New Revision: 1777453
>>
>> URL: http://svn.apache.org/viewvc?rev=1777453&view=rev
>> Log:
>> Promote r1753592 as showstopper, since it also fixes build with MSVC.
>> (Not worth fixing the build if we can backport this change, two fixes for the price of one :)
>>
>> Modified:
>>     httpd/httpd/branches/2.2.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.2.x/STATUS
>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1777453&r1=1777452&r2=1777453&view=diff
>> ==============================================================================
>> --- httpd/httpd/branches/2.2.x/STATUS (original)
>> +++ httpd/httpd/branches/2.2.x/STATUS Thu Jan  5 11:39:58 2017
>> @@ -102,6 +102,16 @@ RELEASE SHOWSTOPPERS:
>>  PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>>    [ start all new proposals below, under PATCHES PROPOSED. ]
>>
>> +  *) mod_proxy: Correctly consider error response codes by the backend when
>> +     processing failonstatus. PR 59869
>> +      Trunk version of patch:
>> +         http://svn.apache.org/r1753592
>> +      Backport version for 2.4.x of patch:
>> +         http://svn.apache.org/r1756562
>> +      Backport version for 2.2.x of patch:
>> +         http://home.apache.org/~ylavic/patches/httpd-2.2.x-r1753592.patch
>> +      +1: ylavic
>
> Ouch, really meant SHOWSTOPPER here, and moved it to the wrong section.
> Re-moved in r1777740, c89 issue which would be unfortunate to fix
> without addressing PR 59869 at the same time...

Thought that's what you might have meant, but the showstopper is the smallest
patch that solves the gating issue. (I know, three non-reviewers of the recent
security refactoring are laughing their a$$e$ off at such a comment from me :)

Seems it has the votes, so we can start moving forwards, too bad so many
compiler solutions are so happy to accept c++ syntax for c sources without
a whimper.

Re: svn commit: r1777453 - /httpd/httpd/branches/2.2.x/STATUS

Posted by Yann Ylavic <yl...@gmail.com>.
On Thu, Jan 5, 2017 at 12:39 PM,  <yl...@apache.org> wrote:
> Author: ylavic
> Date: Thu Jan  5 11:39:58 2017
> New Revision: 1777453
>
> URL: http://svn.apache.org/viewvc?rev=1777453&view=rev
> Log:
> Promote r1753592 as showstopper, since it also fixes build with MSVC.
> (Not worth fixing the build if we can backport this change, two fixes for the price of one :)
>
> Modified:
>     httpd/httpd/branches/2.2.x/STATUS
>
> Modified: httpd/httpd/branches/2.2.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=1777453&r1=1777452&r2=1777453&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.2.x/STATUS (original)
> +++ httpd/httpd/branches/2.2.x/STATUS Thu Jan  5 11:39:58 2017
> @@ -102,6 +102,16 @@ RELEASE SHOWSTOPPERS:
>  PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>    [ start all new proposals below, under PATCHES PROPOSED. ]
>
> +  *) mod_proxy: Correctly consider error response codes by the backend when
> +     processing failonstatus. PR 59869
> +      Trunk version of patch:
> +         http://svn.apache.org/r1753592
> +      Backport version for 2.4.x of patch:
> +         http://svn.apache.org/r1756562
> +      Backport version for 2.2.x of patch:
> +         http://home.apache.org/~ylavic/patches/httpd-2.2.x-r1753592.patch
> +      +1: ylavic

Ouch, really meant SHOWSTOPPER here, and moved it to the wrong section.
Re-moved in r1777740, c89 issue which would be unfortunate to fix
without addressing PR 59869 at the same time...