You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/26 17:07:25 UTC
[GitHub] [beam] boyuanzz commented on a change in pull request #11224:
[BEAM-9340] Validate pipeline requirements in PipelineValidator.
boyuanzz commented on a change in pull request #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.
URL: https://github.com/apache/beam/pull/11224#discussion_r398741485
##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/PipelineValidator.java
##########
@@ -221,23 +229,39 @@ private static void validateParDo(String id, PTransform transform, Components co
id,
sideInputId);
}
- // TODO: Validate state_specs and timer_specs
+ if (payload.getStateSpecsCount() > 0 || payload.getTimerSpecsCount() > 0) {
Review comment:
Ack. can we merge it as soon as possible? Then I can rebase my changes on top of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services