You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/08 02:16:53 UTC

[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4775: [ISSUE #4776]Support tag in litepullconsumer assign mode

tsunghanjacktsai commented on code in PR #4775:
URL: https://github.com/apache/rocketmq/pull/4775#discussion_r939771824


##########
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java:
##########
@@ -271,6 +271,11 @@ public void assign(Collection<MessageQueue> messageQueues) {
         defaultLitePullConsumerImpl.assign(queuesWithNamespace(messageQueues));
     }
 
+    @Override
+    public void setSubExpression4Assgin(final String topic, final String subExpresion) {

Review Comment:
   `setSubExpression4Assgin` -> `setSubExpression4Assign`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org