You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by sk...@apache.org on 2020/10/12 18:29:57 UTC
[phoenix] branch 4.x updated: PHOENIX-6183 Page size tests are not
propagating test override values to server (#914)
This is an automated email from the ASF dual-hosted git repository.
skadam pushed a commit to branch 4.x
in repository https://gitbox.apache.org/repos/asf/phoenix.git
The following commit(s) were added to refs/heads/4.x by this push:
new acb2123 PHOENIX-6183 Page size tests are not propagating test override values to server (#914)
acb2123 is described below
commit acb2123f0c84879309054addc20383f4aa2fae9f
Author: tkhurana <kh...@gmail.com>
AuthorDate: Mon Oct 12 11:26:33 2020 -0700
PHOENIX-6183 Page size tests are not propagating test override values to server (#914)
Tests are creating a new conf object and setting the
INDEX_REBUILD_PAGE_SIZE_IN_ROWS parameter. Pass that conf object to the
IndexTool.
---
.../phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java
index a32bd9c..5653029 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java
@@ -1116,7 +1116,8 @@ public class IndexToolForNonTxGlobalIndexIT extends BaseUniqueNamesOwnClusterIT
// Run the index MR job and verify that the index table is built correctly
Configuration conf = new Configuration(getUtility().getConfiguration());
conf.set(QueryServices.INDEX_REBUILD_PAGE_SIZE_IN_ROWS, Long.toString(2));
- IndexTool indexTool = IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.BEFORE, new String[0]);
+ IndexTool indexTool = IndexToolIT.runIndexTool(conf, directApi, useSnapshot, schemaName, dataTableName,
+ indexTableName, null, 0, IndexTool.IndexVerifyType.BEFORE, IndexTool.IndexDisableLoggingType.NONE, new String[0]);
assertEquals(NROWS, indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
assertEquals(NROWS, indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
assertEquals(NROWS, indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
@@ -1148,9 +1149,9 @@ public class IndexToolForNonTxGlobalIndexIT extends BaseUniqueNamesOwnClusterIT
Configuration conf = new Configuration(getUtility().getConfiguration());
conf.set(QueryServices.INDEX_REBUILD_PAGE_SIZE_IN_ROWS, Long.toString(1));
IndexTool indexTool =
- IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName,
+ IndexToolIT.runIndexTool(conf, directApi, useSnapshot, schemaName,
dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.BEFORE,
- new String[0]);
+ IndexTool.IndexDisableLoggingType.NONE ,new String[0]);
assertEquals(3, indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
assertEquals(3,
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
@@ -1201,9 +1202,9 @@ public class IndexToolForNonTxGlobalIndexIT extends BaseUniqueNamesOwnClusterIT
Configuration conf = new Configuration(getUtility().getConfiguration());
conf.set(QueryServices.INDEX_REBUILD_PAGE_SIZE_IN_ROWS, Long.toString(2));
IndexTool indexTool =
- IndexToolIT.runIndexTool(directApi, useSnapshot, schemaName,
+ IndexToolIT.runIndexTool(conf, directApi, useSnapshot, schemaName,
dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.AFTER,
- "-st", String.valueOf(minTs), "-et",
+ IndexTool.IndexDisableLoggingType.NONE, "-st", String.valueOf(minTs), "-et",
String.valueOf(EnvironmentEdgeManager.currentTimeMillis()));
assertEquals(3, indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
assertEquals(3,