You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mohit Sabharwal <mo...@cloudera.com> on 2014/10/06 23:43:48 UTC
Review Request 26385: HIVE-8338 : Add ip and command to semantic
analyzer hook context
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26385/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-8338
https://issues.apache.org/jira/browse/HIVE-8338
Repository: hive-git
Description
-------
HIVE-8338 : Add ip and command to semantic analyzer hook context
This is useful for semantic analysis hooks like Sentry
when reporting authorization outcomes.
Diffs
-----
itests/hive-minikdc/pom.xml 0bb78a3a0a6cd158f9ed0bda62a6222bc10190f6
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java e11466dc19a14fdf5f795ea6b77ab74c94d13ede
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 06767582f0130a245b09a0c78f8e5f5076e393ca
ql/src/java/org/apache/hadoop/hive/ql/Driver.java a105eca338122a0df09d9b126ebc5dc760721d9e
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContext.java 8694d07ac6c85f2ce2a82de32abb23d4147c9e5a
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java 4f6dad4909be9a29ef5a92addda9e674a28606e9
Diff: https://reviews.apache.org/r/26385/diff/
Testing
-------
Added unit test
Thanks,
Mohit Sabharwal
Re: Review Request 26385: HIVE-8338 : Add ip and command to semantic
analyzer hook context
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26385/#review55608
-----------------------------------------------------------
Thank you for this cleanup! I have one comment which needs to be addressed but otherwise I am quite happy. Nice work!
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java
<https://reviews.apache.org/r/26385/#comment95968>
Since we'll be sharing these static values across test runs in the same JVM we should set these values to null before the test run.
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java
<https://reviews.apache.org/r/26385/#comment95969>
Same here
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java
<https://reviews.apache.org/r/26385/#comment95970>
And here
- Brock Noland
On Oct. 6, 2014, 9:43 p.m., Mohit Sabharwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26385/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2014, 9:43 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-8338
> https://issues.apache.org/jira/browse/HIVE-8338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-8338 : Add ip and command to semantic analyzer hook context
>
> This is useful for semantic analysis hooks like Sentry
> when reporting authorization outcomes.
>
>
> Diffs
> -----
>
> itests/hive-minikdc/pom.xml 0bb78a3a0a6cd158f9ed0bda62a6222bc10190f6
> itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java e11466dc19a14fdf5f795ea6b77ab74c94d13ede
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 06767582f0130a245b09a0c78f8e5f5076e393ca
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java a105eca338122a0df09d9b126ebc5dc760721d9e
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContext.java 8694d07ac6c85f2ce2a82de32abb23d4147c9e5a
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java 4f6dad4909be9a29ef5a92addda9e674a28606e9
>
> Diff: https://reviews.apache.org/r/26385/diff/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Mohit Sabharwal
>
>
Re: Review Request 26385: HIVE-8338 : Add ip and command to semantic
analyzer hook context
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26385/#review56047
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Oct. 7, 2014, 12:22 a.m., Mohit Sabharwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26385/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 12:22 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-8338
> https://issues.apache.org/jira/browse/HIVE-8338
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-8338 : Add ip and command to semantic analyzer hook context
>
> This is useful for semantic analysis hooks like Sentry
> when reporting authorization outcomes.
>
>
> Diffs
> -----
>
> itests/hive-minikdc/pom.xml 0bb78a3a0a6cd158f9ed0bda62a6222bc10190f6
> itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java e11466dc19a14fdf5f795ea6b77ab74c94d13ede
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 06767582f0130a245b09a0c78f8e5f5076e393ca
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java a105eca338122a0df09d9b126ebc5dc760721d9e
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContext.java 8694d07ac6c85f2ce2a82de32abb23d4147c9e5a
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java 4f6dad4909be9a29ef5a92addda9e674a28606e9
>
> Diff: https://reviews.apache.org/r/26385/diff/
>
>
> Testing
> -------
>
> Added unit test
>
>
> Thanks,
>
> Mohit Sabharwal
>
>
Re: Review Request 26385: HIVE-8338 : Add ip and command to semantic
analyzer hook context
Posted by Mohit Sabharwal <mo...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26385/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 12:22 a.m.)
Review request for hive.
Changes
-------
Inc. feedback.
Bugs: HIVE-8338
https://issues.apache.org/jira/browse/HIVE-8338
Repository: hive-git
Description
-------
HIVE-8338 : Add ip and command to semantic analyzer hook context
This is useful for semantic analysis hooks like Sentry
when reporting authorization outcomes.
Diffs (updated)
-----
itests/hive-minikdc/pom.xml 0bb78a3a0a6cd158f9ed0bda62a6222bc10190f6
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java e11466dc19a14fdf5f795ea6b77ab74c94d13ede
itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 06767582f0130a245b09a0c78f8e5f5076e393ca
ql/src/java/org/apache/hadoop/hive/ql/Driver.java a105eca338122a0df09d9b126ebc5dc760721d9e
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContext.java 8694d07ac6c85f2ce2a82de32abb23d4147c9e5a
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveSemanticAnalyzerHookContextImpl.java 4f6dad4909be9a29ef5a92addda9e674a28606e9
Diff: https://reviews.apache.org/r/26385/diff/
Testing
-------
Added unit test
Thanks,
Mohit Sabharwal