You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 00:08:07 UTC
[GitHub] [spark] dmsolow opened a new pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
dmsolow opened a new pull request #31887:
URL: https://github.com/apache/spark/pull/31887
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Increment a global counter and use the current value to name LambdaVariables created by higher order functions.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This moves away from the current hard-coded variable names which break on nested function calls. There is currently a bug where nested transforms in particular fail (the inner variable shadows the outer variable)
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I'm not sure how to test this because the current tests don't run the `functions.transform` directly
@nvander1 @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813386893
pinging @maropu, @HyukjinKwon
This correctness related PR has gone unnoticed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-828114614
> @maropu I won't be able to work on this until June 1, other duties are getting in the way.
Ah, I see. Is it okay that I take this over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-828108481
cc @ueshin too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813768985
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RussellSpitzer commented on a change in pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #31887:
URL: https://github.com/apache/spark/pull/31887#discussion_r597384076
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -3799,23 +3801,26 @@ object functions {
ArrayExcept(col1.expr, col2.expr)
}
+ // counter to ensure lambdra variable names unique
Review comment:
Typo in lambda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802402952
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] RussellSpitzer commented on pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802458349
I think your example from slack would be prefect as a test. Especially because of the divergent behavior between Spark SQL and the programmatic api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813750553
`branch-3.0` has the same issue? Also, could you describe more in the PR description? It should be self-contained for commit logs, I think (Its okay to just copy&paste the example query in the jira)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dmsolow commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
dmsolow commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-828405375
> > @maropu I won't be able to work on this until June 1, other duties are getting in the way.
>
> Ah, I see. Is it okay that I take this over?
Go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-826608422
Kindly ping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31887:
URL: https://github.com/apache/spark/pull/31887#discussion_r607421098
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -3799,23 +3801,26 @@ object functions {
ArrayExcept(col1.expr, col2.expr)
}
+ // counter to ensure lambda variable names are unique
+ private val lambdaVarNameCounter = new AtomicInteger(0)
Review comment:
How about defining a companion object for UnresolvedNamedLambdaVariable like this?
```
object UnresolvedNamedLambdaVariable {
// counter to ensure lambda variable names are unique
private val lambdaVarNameCounter = new AtomicInteger(0)
def apply(args: Seq[String]): UnresolvedNamedLambdaVariable = {
// add a counter number in the suffix
}
}
```
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -2261,6 +2261,32 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSparkSession {
assert(ex3.getMessage.contains("cannot resolve 'a'"))
}
+ test("nested transform (DSL)") {
Review comment:
nit: `nested transform (DSL)` -> `SPARK-34794: nested transform`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala
##########
@@ -2261,6 +2261,32 @@ class DataFrameFunctionsSuite extends QueryTest with SharedSparkSession {
assert(ex3.getMessage.contains("cannot resolve 'a'"))
}
+ test("nested transform (DSL)") {
+ val df = Seq(
+ (Seq(1, 2, 3), Seq("a", "b", "c"))
+ ).toDF("numbers", "letters")
+
+ checkAnswer(
+ df.select(
+ flatten(
+ transform(
+ $"numbers",
+ (number: Column) => transform(
Review comment:
I think we need exhaustive tests for this issue, e.g., two/three argument cases and their combination cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dmsolow commented on pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
dmsolow commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802518964
@nvander1 test added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813751239
**[Test build #136924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136924/testReport)** for PR 31887 at commit [`8c2ad61`](https://github.com/apache/spark/commit/8c2ad611bf6aa4a0acdbebc6f78248d0a2a6ac9e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813749239
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813848484
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dmsolow commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
dmsolow commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-827640788
@maropu I won't be able to work on this until June 1, other duties are getting in the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] nvander1 commented on pull request #31887: [WIP][SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
nvander1 commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802454281
Maybe you can make a test with an example of the shadowing to demonstrate how it works correctly now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813837892
**[Test build #136924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136924/testReport)** for PR 31887 at commit [`8c2ad61`](https://github.com/apache/spark/commit/8c2ad611bf6aa4a0acdbebc6f78248d0a2a6ac9e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31887:
URL: https://github.com/apache/spark/pull/31887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813768985
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41501/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813848484
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136924/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31887: [SPARK-34794][SQL] Fix nested transform issue
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813766925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-813751239
**[Test build #136924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136924/testReport)** for PR 31887 at commit [`8c2ad61`](https://github.com/apache/spark/commit/8c2ad611bf6aa4a0acdbebc6f78248d0a2a6ac9e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31887: [SPARK-34794][SQL] fix nested transform issue
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31887:
URL: https://github.com/apache/spark/pull/31887#issuecomment-802402952
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org