You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Galen O'Sullivan (JIRA)" <ji...@apache.org> on 2017/06/09 21:25:18 UTC
[jira] [Updated] (GEODE-3059) LoadMonitor.connectionClosed
incrementing statistics only for client-server connection
[ https://issues.apache.org/jira/browse/GEODE-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Galen O'Sullivan updated GEODE-3059:
------------------------------------
Component/s: client/server
> LoadMonitor.connectionClosed incrementing statistics only for client-server connection
> --------------------------------------------------------------------------------------
>
> Key: GEODE-3059
> URL: https://issues.apache.org/jira/browse/GEODE-3059
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Galen O'Sullivan
>
> The logic in {{LoadMonitor.connectionClosed}} looks wrong, or at least is quite counterintuitive. The connection count is decremented only if this is a client-server connection, which looks wrong, and the client count should be only if it's a client-to-server connection.
> We need to look at Gateway connections as well, and for the new client-server protocol.
> {code}
> public void connectionClosed(boolean lastConnection, byte communicationMode) {
> if (communicationMode == Acceptor.CLIENT_TO_SERVER) {
> metrics.decConnectionCount();
> }
> if (lastConnection) {
> metrics.decClientCount();
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)