[jira] [Commented] (IGNITE-602) [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion

["Alexey Goncharuk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576275#comment-16576275 ] 

Alexey Goncharuk commented on IGNITE-602:
-----------------------------------------

[~SomeFire], this change breaks {{S.toString()}} output, this is the printout I see in logs:
{code}
[2018-08-10 16:14:15,671][WARN ][exchange-worker-#186%client%][diagnostic] >>> KeyCacheObjectImpl [part=6, val=6, hasValBytes=true]KeyCacheObjectImpl [part=6, val=6, hasValBytes=true], val=null, ver=GridCacheVersion [topVer=0, order=0, nodeOrder=0], hash=6, extras=null, flags=0]GridDistributedCacheEntry [super=]GridDhtDetachedCacheEntry [super=], prepared=0, locked=false, nodeId=834e31ba-a000-46d5-bef3-45f285300001, locMapped=false, expiryPlc=null, transferExpiryPlc=false, flags=0, partUpdateCntr=0, serReadVer=null, xidVer=GridCacheVersion [topVer=145386834, order=1533906834364, nodeOrder=4]]]], super=, size=1]GridDhtTxLocalAdapter [nearOnOriginatingNode=false, nearNodes=KeySetView [], dhtNodes=KeySetView [], explicitLock=false, super=]GridNearTxLocal [mappings=IgniteTxMappingsImpl [], nearLocallyMapped=false, colocatedLocallyMapped=false, needCheckBackup=null, hasRemoteLocks=false, trackTimeout=false, lb=null, thread=async-runnable-runner-1, mappings=IgniteTxMappingsImpl [], super=], super=GridCompoundFuture [rdc=o.a.i.i.processors.cache.distributed.near.GridNearTxPrepareFutureAdapter$1@4f11fa96, initFlag=1, lsnrCalls=0, done=false, cancelled=false, err=null, futs=TransformCollectionView [false]]]
{code}

Can you estimate how long the fix will take? If it takes too long, we will need to revert the change.

> [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion
> --------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-602
>                 URL: https://issues.apache.org/jira/browse/IGNITE-602
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>            Reporter: Artem Shutak
>            Assignee: Ryabov Dmitrii
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain, Muted_test
>             Fix For: 2.7
>
>
> See test org.gridgain.grid.util.tostring.GridToStringBuilderSelfTest#_testToStringCheckAdvancedRecursionPrevention and related TODO in same source file.
> Also take a look at http://stackoverflow.com/questions/11300203/most-efficient-way-to-prevent-an-infinite-recursion-in-tostring
> Test should be unmuted on TC after fix.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)