[GitHub] [superset] pkdotson commented on a change in pull request #18722: feat: DBC-UI Globally available across the app 🌎

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #18722:
URL: https://github.com/apache/superset/pull/18722#discussion_r810258117



##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -123,11 +129,19 @@ const RightMenu = ({
   const { roles } = useSelector<any, UserWithPermissionsAndRoles>(
     state => state.user,
   );
+  const [showModal, setShowModal] = useState<boolean>(false);
+  const [engine, setEngine] = useState<string>('');
   // @ts-ignore
   const { CSV_EXTENSIONS, COLUMNAR_EXTENSIONS, EXCEL_EXTENSIONS } = useSelector<
     any,
     CommonBootstrapData
   >(state => state.common.conf);
+
+  // @ts-ignore
+  const { SHOW_GLOBAL_GSHEETS } = useSelector<any, CommonBootstrapData>(

Review comment:
       You should be able to get rid of this ts-ignore if you replace CommonBootstrapData with a new type. For ex... 
   `interface NewType {
       Show_GLOBAL_GSHEETS: BOOLEAN;
   }
   const { SHOW_GLOBAL_GSHEETS } = useSelector<any, NewType> {....
   `
   I just figured this out in my current open pr. lol




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org