You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Alan M. Carroll (JIRA)" <ji...@apache.org> on 2010/05/05 17:15:02 UTC
[jira] Created: (TS-333) Remove SocketManager::fast_close
Remove SocketManager::fast_close
--------------------------------
Key: TS-333
URL: https://issues.apache.org/jira/browse/TS-333
Project: Traffic Server
Issue Type: Improvement
Components: Network
Affects Versions: 2.0.0
Reporter: Alan M. Carroll
Priority: Trivial
"There were fast path(s) in the SocketXXX code when used with a kernel
non-native BSD-TCP stack on certain platforms. In the current "cleansed"
code base this is no longer applicable/supported." - George Paul
Remove SocketManager::fast_close and change all uses to SocketManager::close.
Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-333) Remove SocketManager::fast_close
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864828#action_12864828 ]
Alan M. Carroll commented on TS-333:
------------------------------------
Patch is written and (very lightly) tested. I need to construct a test bed suitable for running the regression tests so I can verify the fix (and others).
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Priority: Trivial
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-333) Remove SocketManager::fast_close
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-333:
-------------------------------
Attachment: (was: ts-333-2-1-0-patch.txt)
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Priority: Trivial
> Attachments: ts-333-2-1-0-patch.txt
>
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-333) Remove SocketManager::fast_close
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-333:
-------------------------------
Attachment: ts-333-patch-trunk.txt
Updated patched to be against trunk.
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Priority: Trivial
> Attachments: ts-333-2-1-0-patch.txt, ts-333-patch-trunk.txt
>
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-333) Remove SocketManager::fast_close
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk resolved TS-333.
----------------------------
Assignee: Mladen Turk
Fix Version/s: 2.1.1
Resolution: Fixed
Committed to trunk. Thanks.
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Assignee: Mladen Turk
> Priority: Trivial
> Fix For: 2.1.1
>
> Attachments: ts-333-2-1-0-patch.txt, ts-333-patch-trunk.txt
>
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-333) Remove SocketManager::fast_close
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-333:
-------------------------------
Attachment: ts-333-2-1-0-patch.txt
Patch updated with suggestions from mturk
* In SocketManager::close
** Used int instead of SOCKET
** Checked syscall return against -1 instead of < 0
** Removed printf, return -EACCES or -EINVAL for bad values of parameter
* Fixed first two in SocketManager::ink_bind also
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Priority: Trivial
> Attachments: ts-333-2-1-0-patch.txt, ts-333-2-1-0-patch.txt
>
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-333) Remove SocketManager::fast_close
Posted by "Alan M. Carroll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-333:
-------------------------------
Attachment: ts-333-2-1-0-patch.txt
Patch generated using SVN diff against the 2.1.0 codebase.
> Remove SocketManager::fast_close
> --------------------------------
>
> Key: TS-333
> URL: https://issues.apache.org/jira/browse/TS-333
> Project: Traffic Server
> Issue Type: Improvement
> Components: Network
> Affects Versions: 2.0.0
> Reporter: Alan M. Carroll
> Priority: Trivial
> Attachments: ts-333-2-1-0-patch.txt
>
>
> "There were fast path(s) in the SocketXXX code when used with a kernel
> non-native BSD-TCP stack on certain platforms. In the current "cleansed"
> code base this is no longer applicable/supported." - George Paul
> Remove SocketManager::fast_close and change all uses to SocketManager::close.
> Remove obsolete argument from SocketManager::close.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.