You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/01 15:52:45 UTC
[GitHub] [beam] robertwb opened a new pull request, #22994: Fix nested optional row inference.
robertwb opened a new pull request, #22994:
URL: https://github.com/apache/beam/pull/22994
This was broken in 2.40 and exposed by cross-langauge work.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #22994:
URL: https://github.com/apache/beam/pull/22994#issuecomment-1234569725
That is probably a better fix--didn't realize making it callable was all that was needed to make Optional[RowType] work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb closed pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
robertwb closed pull request #22994: Fix nested optional row inference.
URL: https://github.com/apache/beam/pull/22994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22994:
URL: https://github.com/apache/beam/pull/22994#issuecomment-1234550150
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
robertwb commented on PR #22994:
URL: https://github.com/apache/beam/pull/22994#issuecomment-1234471324
R: @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22994:
URL: https://github.com/apache/beam/pull/22994#issuecomment-1234619485
> That is probably a better fix--didn't realize making it callable was all that was needed to make Optional[RowType] work.
Yeah for now it looks like CPython considers anything callable to be a type. In 3.11 it may become even more permissive: https://github.com/apache/beam/pull/22899#discussion_r955550117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22994: Fix nested optional row inference.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22994:
URL: https://github.com/apache/beam/pull/22994#issuecomment-1234491793
Note a user reported #22854 which was addressed in #22899. I'm not sure we need this patch, isn't it appropriate to create an Optional[RowTypeConstraint] for a nullable nested struct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org