[GitHub] johnyangk commented on a change in pull request #85: [NEMO-172] Implement one partition per one element partitioner

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #85: [NEMO-172] Implement one partition per one element partitioner
URL: https://github.com/apache/incubator-nemo/pull/85#discussion_r208070887
 
 

 ##########
 File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/data/block/Block.java
 ##########
 @@ -103,13 +103,24 @@
    * Commits this block to prevent further write.
    *
    * @return the size of each partition if the data in the block is serialized.
-   * @throws BlockWriteException for any error occurred while trying to write a block.
+   * @throws BlockWriteException for any error occurred while trying to commit a block.
    *                             (This exception will be thrown to the scheduler
    *                             through {@link edu.snu.nemo.runtime.executor.Executor} and
    *                             have to be handled by the scheduler with fault tolerance mechanism.)
    */
   Optional<Map<K, Long>> commit() throws BlockWriteException;
 
+  /**
+   * Commits all un-committed partitions.
+   * If another element is written after this method is called, a new non-committed partition should be created
 
 Review comment:
   I understood that this method is expected to be called multiple times.
   Can you also mention here when and under which conditions this method is invoked?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services