You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by jean-frederic clere <jf...@gmail.com> on 2007/06/27 17:09:44 UTC
apr_table_setn in mod_proxy_balancer.c
Hi,
In mod_proxy_balancer.c there is the following code:
+++
/* Add the session route to request notes if present */
if (route) {
apr_table_setn(r->notes, "session-sticky", (*balancer)->sticky);
apr_table_setn(r->notes, "session-route", route);
/* Add session info to env. */
apr_table_setn(r->subprocess_env,
"BALANCER_SESSION_STICKY", (*balancer)->sticky);
apr_table_setn(r->subprocess_env,
"BALANCER_SESSION_ROUTE", route);
}
+++
"session-route" is SC_A_JVM_ROUTE in AJP but what are the purpose of the
others?
Cheers
Jean-Frederic
Re: apr_table_setn in mod_proxy_balancer.c
Posted by jean-frederic clere <jf...@gmail.com>.
Ruediger Pluem wrote:
>
> On 06/27/2007 05:09 PM, jean-frederic clere wrote:
>> Hi,
>>
>> In mod_proxy_balancer.c there is the following code:
>> +++
>> /* Add the session route to request notes if present */
>> if (route) {
>> apr_table_setn(r->notes, "session-sticky", (*balancer)->sticky);
>> apr_table_setn(r->notes, "session-route", route);
>>
>> /* Add session info to env. */
>> apr_table_setn(r->subprocess_env,
>> "BALANCER_SESSION_STICKY", (*balancer)->sticky);
>> apr_table_setn(r->subprocess_env,
>> "BALANCER_SESSION_ROUTE", route);
>> }
>> +++
>> "session-route" is SC_A_JVM_ROUTE in AJP but what are the purpose of the
>> others?
>
> Does
>
> http://httpd.apache.org/docs/2.2/en/mod/mod_proxy_balancer.html#environment
>
> answer this question?
It does. Now I see the problem with the sticky/sticky_path logic: we are
not filling BALANCER_SESSION_STICKY with the right value when using
sticky_path.
Cheers
Jean-Frederic
>
> Regards
>
> Rüdiger
>
>
Re: apr_table_setn in mod_proxy_balancer.c
Posted by Plüm,
Rüdiger,
VF-Group <ru...@vodafone.com>.
> -----Ursprüngliche Nachricht-----
> Von: jean-frederic clere
> Gesendet: Montag, 9. Juli 2007 16:29
> An: dev@httpd.apache.org
> Betreff: Re: apr_table_setn in mod_proxy_balancer.c
>
>
> jean-frederic clere wrote:
> > Ruediger Pluem wrote:
> >>
> >> On 06/27/2007 05:09 PM, jean-frederic clere wrote:
> >>> Hi,
> >>>
> >>> In mod_proxy_balancer.c there is the following code:
> >>> +++
> >>> /* Add the session route to request notes if present */
> >>> if (route) {
> >>> apr_table_setn(r->notes, "session-sticky",
> (*balancer)->sticky);
> >>> apr_table_setn(r->notes, "session-route", route);
> >>>
> >>> /* Add session info to env. */
> >>> apr_table_setn(r->subprocess_env,
> >>> "BALANCER_SESSION_STICKY",
> (*balancer)->sticky);
> >>> apr_table_setn(r->subprocess_env,
> >>> "BALANCER_SESSION_ROUTE", route);
> >>> }
> >>> +++
> >>> "session-route" is SC_A_JVM_ROUTE in AJP but what are the
> purpose of the
> >>> others?
> >>
> >> Does
> >>
> >>
> http://httpd.apache.org/docs/2.2/en/mod/mod_proxy_balancer.htm
l#environment
>>
>>
>> answer this question?
>
> So I have to propose the attached patch to get
> http://svn.apache.org/viewvc?view=rev&rev=551935 and
> http://svn.apache.org/viewvc?view=rev&rev=550519 correct.,
Looks good to me.
Regards
Rüdiger
Re: apr_table_setn in mod_proxy_balancer.c
Posted by jean-frederic clere <jf...@gmail.com>.
jean-frederic clere wrote:
> Ruediger Pluem wrote:
>>
>> On 06/27/2007 05:09 PM, jean-frederic clere wrote:
>>> Hi,
>>>
>>> In mod_proxy_balancer.c there is the following code:
>>> +++
>>> /* Add the session route to request notes if present */
>>> if (route) {
>>> apr_table_setn(r->notes, "session-sticky", (*balancer)->sticky);
>>> apr_table_setn(r->notes, "session-route", route);
>>>
>>> /* Add session info to env. */
>>> apr_table_setn(r->subprocess_env,
>>> "BALANCER_SESSION_STICKY", (*balancer)->sticky);
>>> apr_table_setn(r->subprocess_env,
>>> "BALANCER_SESSION_ROUTE", route);
>>> }
>>> +++
>>> "session-route" is SC_A_JVM_ROUTE in AJP but what are the purpose of the
>>> others?
>>
>> Does
>>
>> http://httpd.apache.org/docs/2.2/en/mod/mod_proxy_balancer.html#environment
>>
>>
>> answer this question?
>
> So I have to propose the attached patch to get
> http://svn.apache.org/viewvc?view=rev&rev=551935 and
> http://svn.apache.org/viewvc?view=rev&rev=550519 correct.,
Oops the attachment was missing... Sorry.
Cheers
Jean-Frederic
>
> Comments?
>
> Cheers
>
> Jean-Frederic
>
>>
>> Regards
>>
>> Rüdiger
>>
>>
>
>
Re: apr_table_setn in mod_proxy_balancer.c
Posted by jean-frederic clere <jf...@gmail.com>.
Ruediger Pluem wrote:
>
> On 06/27/2007 05:09 PM, jean-frederic clere wrote:
>> Hi,
>>
>> In mod_proxy_balancer.c there is the following code:
>> +++
>> /* Add the session route to request notes if present */
>> if (route) {
>> apr_table_setn(r->notes, "session-sticky", (*balancer)->sticky);
>> apr_table_setn(r->notes, "session-route", route);
>>
>> /* Add session info to env. */
>> apr_table_setn(r->subprocess_env,
>> "BALANCER_SESSION_STICKY", (*balancer)->sticky);
>> apr_table_setn(r->subprocess_env,
>> "BALANCER_SESSION_ROUTE", route);
>> }
>> +++
>> "session-route" is SC_A_JVM_ROUTE in AJP but what are the purpose of the
>> others?
>
> Does
>
> http://httpd.apache.org/docs/2.2/en/mod/mod_proxy_balancer.html#environment
>
> answer this question?
So I have to propose the attached patch to get
http://svn.apache.org/viewvc?view=rev&rev=551935 and
http://svn.apache.org/viewvc?view=rev&rev=550519 correct.,
Comments?
Cheers
Jean-Frederic
>
> Regards
>
> Rüdiger
>
>
Re: apr_table_setn in mod_proxy_balancer.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 06/27/2007 05:09 PM, jean-frederic clere wrote:
> Hi,
>
> In mod_proxy_balancer.c there is the following code:
> +++
> /* Add the session route to request notes if present */
> if (route) {
> apr_table_setn(r->notes, "session-sticky", (*balancer)->sticky);
> apr_table_setn(r->notes, "session-route", route);
>
> /* Add session info to env. */
> apr_table_setn(r->subprocess_env,
> "BALANCER_SESSION_STICKY", (*balancer)->sticky);
> apr_table_setn(r->subprocess_env,
> "BALANCER_SESSION_ROUTE", route);
> }
> +++
> "session-route" is SC_A_JVM_ROUTE in AJP but what are the purpose of the
> others?
Does
http://httpd.apache.org/docs/2.2/en/mod/mod_proxy_balancer.html#environment
answer this question?
Regards
Rüdiger