You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/21 09:24:17 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #985: [CELEBORN-4] Add metrics about top disk used apps.
FMX opened a new pull request, #985:
URL: https://github.com/apache/incubator-celeborn/pull/985
# [CELEBORN-4] Add metrics about top disk used apps.
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #985: [CELEBORN-4] Add metrics about top disk used apps.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #985:
URL: https://github.com/apache/incubator-celeborn/pull/985#discussion_r1028973512
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -100,10 +100,11 @@ public ResourceResponse handleWriteRequest(ResourceProtos.ResourceRequest reques
int pushPort;
int fetchPort;
int replicatePort;
- Map<String, DiskInfo> disks;
+ Map<String, DiskInfo> diskUsage;
Map<UserIdentifier, ResourceConsumption> userResourceConsumption;
List<Map<String, Integer>> slots = new ArrayList<>();
Map<String, Map<String, Integer>> workerAllocations = new HashMap<>();
+ Map<String, Long> shuffleDiskUsage = new HashMap<>();
Review Comment:
appDiskUsage
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -138,7 +138,7 @@ message PbHeartbeatFromWorker {
int32 fetchPort = 4;
int32 replicatePort = 5;
repeated PbDiskInfo disks = 6;
- repeated string shuffleKeys = 7;
+ map<string, int64> shuffleDiskUsage = 7;
Review Comment:
This change will break the behavior of identifying expired shuffles in handleHeartbeatFromWorker.
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -100,10 +100,11 @@ public ResourceResponse handleWriteRequest(ResourceProtos.ResourceRequest reques
int pushPort;
int fetchPort;
int replicatePort;
- Map<String, DiskInfo> disks;
+ Map<String, DiskInfo> diskUsage;
Review Comment:
diskInfos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #985: [CELEBORN-4] Add metrics about top disk used apps.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #985:
URL: https://github.com/apache/incubator-celeborn/pull/985#discussion_r1029153489
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -138,9 +138,10 @@ message PbHeartbeatFromWorker {
int32 fetchPort = 4;
int32 replicatePort = 5;
repeated PbDiskInfo disks = 6;
- repeated string shuffleKeys = 7;
+ repeated string activeShuffleKeys = 7;
string requestId = 8;
map<string, PbResourceConsumption> userResourceConsumption = 9;
+ map<string,int64> estimatedAppDiskUsage = 10;
Review Comment:
Should add space after comma
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -371,6 +371,18 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
hashSet
}
+ def topAppDiskUsage: util.Map[String, Long] = {
+ fileInfos.asScala.map { keyedWriters =>
Review Comment:
We'd better synchronize on fileInfos. See userResourceConsumptionSnapshot
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/metrics/AppDiskUsageMetric.scala:
##########
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.service.deploy.master.metrics
+
+import java.time.LocalDateTime
+import java.util
+import java.util.concurrent.TimeUnit
+import java.util.concurrent.atomic.AtomicReference
+
+import scala.collection.JavaConverters.{iterableAsScalaIterableConverter, mapAsScalaMapConverter}
Review Comment:
Plz delete the unused imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #985: [CELEBORN-4] Add metrics about top disk used apps.
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #985:
URL: https://github.com/apache/incubator-celeborn/pull/985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org