You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/03/25 18:36:59 UTC
Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Sid Wagle.
Bugs: AMBARI-10207
https://issues.apache.org/jira/browse/AMBARI-10207
Repository: ambari
Description
-------
The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 3ac2d0d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
ambari-server/src/main/resources/properties.json 4fee882
ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java 3f21bce
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
Diff: https://reviews.apache.org/r/32488/diff/
Testing
-------
mvn clean test
Thanks,
Dmytro Sen
Re: Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/
-----------------------------------------------------------
(Updated Март 27, 2015, 4:49 п.п.)
Review request for Ambari, Srimanth Gunturi and Sid Wagle.
Bugs: AMBARI-10207
https://issues.apache.org/jira/browse/AMBARI-10207
Repository: ambari
Description
-------
The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 8952153
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutRecommendationCommand.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutValidationCommand.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationDependenciesRecommendationCommand.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommand.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationValidationCommand.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/GetComponentLayoutRecommnedationCommand.java b91f912
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/GetComponentLayoutValidationCommand.java 1a1fc98
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/GetConfigurationRecommnedationCommand.java b20c966
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/GetConfigurationValidationCommand.java 36fe6cb
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java e0480c8
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3586f2d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml aceee50
ambari-server/src/main/resources/properties.json b230cb7
ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml d562246
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 96e7ff2
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommandTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/GetConfigurationRecommnedationCommandTest.java 1bd66a4
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml de723a3
Diff: https://reviews.apache.org/r/32488/diff/
Testing
-------
mvn clean test
Thanks,
Dmytro Sen
Re: Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/
-----------------------------------------------------------
(Updated Март 27, 2015, 4:15 п.п.)
Review request for Ambari, Srimanth Gunturi and Sid Wagle.
Changes
-------
Request
curl 'http://localhost:8080/api/v1/stacks/HDP/versions/2.2/recommendations' -H 'X-Requested-By: X-Requested-By' -H 'X-Requested-With: XMLHttpRequest' --data '{"recommend":"configuration-dependencies","changed_configurations":[{"type":"yarn-site","name":"yarn.nodemanager.resource.memory-mb"}],"hosts":["c6402.ambari.apache.org"],"services":["HDFS","MAPREDUCE2","YARN","ZOOKEEPER"],"recommendations":{"blueprint":{"configurations":{"yarn-site":{"properties":{"yarn.nodemanager.resource.memory-mb": "1280", "yarn.scheduler.minimum-allocation-mb": "256", "yarn.scheduler.maximum-allocation-mb": "1280", "yarn.nodemanager.resource.cpu-vcores": "2"}}, "yarn-env":{"properties":{"min_user_id": "500"}}}, "host_groups":[{"name":"host-group-1","components":[{"name":"NAMENODE"},{"name":"SECONDARY_NAMENODE"},{"name":"HISTORYSERVER"},{"name":"APP_TIMELINE_SERVER"},{"name":"RESOURCEMANAGER"},{"name":"ZOOKEEPER_SERVER"},{"name":"JOURNALNODE"},{"name":"ZKFC"},{"name":"DATANODE"},{"name":"NODEMANAGER"},{"na
me":"HDFS_CLIENT"},{"name":"MAPREDUCE2_CLIENT"},{"name":"YARN_CLIENT"},{"name":"ZOOKEEPER_CLIENT"}]}]},"blueprint_cluster_binding":{"host_groups":[{"name":"host-group-1","hosts":[{"fqdn":"c6402.ambari.apache.org"}]}]}}}' --compressed
Response
{
"resources" : [
{
"href" : "http://localhost:8080/api/v1/stacks/HDP/versions/2.2/recommendations/13",
"hosts" : [
"c6402.ambari.apache.org"
],
"services" : [
"ZOOKEEPER",
"MAPREDUCE2",
"HDFS",
"YARN"
],
"Recommendation" : {
"id" : 13
},
"Versions" : {
"stack_name" : "HDP",
"stack_version" : "2.2"
},
"recommendations" : {
"blueprint" : {
"host_groups" : [
{
"name" : "host-group-1",
"components" : [
{
"name" : "YARN_CLIENT"
},
{
"name" : "NODEMANAGER"
},
{
"name" : "HDFS_CLIENT"
},
{
"name" : "APP_TIMELINE_SERVER"
},
{
"name" : "RESOURCEMANAGER"
},
{
"name" : "DATANODE"
},
{
"name" : "MAPREDUCE2_CLIENT"
},
{
"name" : "NAMENODE"
},
{
"name" : "HISTORYSERVER"
},
{
"name" : "ZOOKEEPER_CLIENT"
},
{
"name" : "ZOOKEEPER_SERVER"
},
{
"name" : "JOURNALNODE"
},
{
"name" : "ZKFC"
},
{
"name" : "SECONDARY_NAMENODE"
}
]
}
],
"configurations" : {
"mapred-site" : {
"properties" : {
"mapreduce.map.memory.mb" : "682",
"mapreduce.reduce.memory.mb" : "682",
"yarn.app.mapreduce.am.command-opts" : "-Xmx546m -Dhdp.version=${hdp.version}",
"mapreduce.reduce.java.opts" : "-Xmx546m",
"yarn.app.mapreduce.am.resource.mb" : "682",
"mapreduce.map.java.opts" : "-Xmx546m",
"mapreduce.task.io.sort.mb" : "273"
}
},
"yarn-site" : {
"properties" : {
"yarn.scheduler.minimum-allocation-mb" : "682",
"yarn.scheduler.maximum-allocation-mb" : "2048",
"yarn.nodemanager.resource.memory-mb" : "1280"
},
"property_attributes" : {
"yarn.scheduler.minimum-allocation-mb" : {
"max" : "1280"
},
"yarn.scheduler.maximum-allocation-mb" : {
"max" : "1280"
},
"yarn.nodemanager.resource.memory-mb" : {
"max" : "1877"
}
}
}
}
},
"blueprint_cluster_binding" : {
"host_groups" : [
{
"name" : "host-group-1",
"hosts" : [
{
"name" : "c6402.ambari.apache.org"
}
]
}
]
}
}
}
]
}
Bugs: AMBARI-10207
https://issues.apache.org/jira/browse/AMBARI-10207
Repository: ambari
Description
-------
The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 8952153
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java e0480c8
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3586f2d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml aceee50
ambari-server/src/main/resources/properties.json b230cb7
ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml d562246
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 96e7ff2
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml de723a3
Diff: https://reviews.apache.org/r/32488/diff/
Testing
-------
mvn clean test
Thanks,
Dmytro Sen
Re: Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Март 27, 2015, 5:42 д.п., Srimanth Gunturi wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, line 331
> > <https://reviews.apache.org/r/32488/diff/2/?file=906701#file906701line331>
> >
> > Each config will have depends-on and depended-by configs. When such config changes, it will be the depended-by that will change, and not the depends-on configs.
Correct. I fill the set with all depended-by properties
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/#review78020
-----------------------------------------------------------
On Март 26, 2015, 3:58 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32488/
> -----------------------------------------------------------
>
> (Updated Март 26, 2015, 3:58 п.п.)
>
>
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
>
>
> Bugs: AMBARI-10207
> https://issues.apache.org/jira/browse/AMBARI-10207
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 3ac2d0d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java e0480c8
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3586f2d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml aceee50
> ambari-server/src/main/resources/properties.json 4fee882
> ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml d562246
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
> ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
> ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8f7c199
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java 3f21bce
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
> ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml de723a3
>
> Diff: https://reviews.apache.org/r/32488/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/#review78020
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
<https://reviews.apache.org/r/32488/#comment126398>
I do not think we want to provide an additional JSON just for configurations metadata of dependencies. We are already giving stack information via the services.json - we need to add configurations metadata to that same JSON.
So basically the stack_advisor.py script still gets 2 JSON files. 1 for all information about services and their configs. 1 for all hosts information. It is then upto the script and the command invoked to use that information and return appropriate dependency updates.
To the current API call we make to populate the services.json, we add additional field requirements to get the 'property_depends_on' and 'property_depended_by' values for all configs into the services.json.
[http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services?fields=configurations/StackConfigurations/property_depends_on,configurations/StackConfigurations/property_depended_by]
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
<https://reviews.apache.org/r/32488/#comment126399>
Each config will have depends-on and depended-by configs. When such config changes, it will be the depended-by that will change, and not the depends-on configs.
- Srimanth Gunturi
On March 26, 2015, 3:58 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32488/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 3:58 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Sid Wagle.
>
>
> Bugs: AMBARI-10207
> https://issues.apache.org/jira/browse/AMBARI-10207
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 3ac2d0d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java e0480c8
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3586f2d
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml aceee50
> ambari-server/src/main/resources/properties.json 4fee882
> ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml d562246
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
> ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
> ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8f7c199
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java 3f21bce
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
> ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml de723a3
>
> Diff: https://reviews.apache.org/r/32488/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32488: BE: Extend stack-advisor to recommend
property_value_attributes
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32488/
-----------------------------------------------------------
(Updated Март 26, 2015, 3:58 п.п.)
Review request for Ambari, Srimanth Gunturi and Sid Wagle.
Bugs: AMBARI-10207
https://issues.apache.org/jira/browse/AMBARI-10207
Repository: ambari
Description
-------
The stack-advisor /recommendations end-point needs to be improved to support enhanced-configs requirements. This includes the support for property_value_attributes.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 3ac2d0d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java 9e683f0
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java 991f198
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java 191aeed
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java 2e20452
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandType.java 380b81d
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/recommendations/RecommendationResponse.java 1796f9a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java 6ae557d
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java e0480c8
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3586f2d
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml aceee50
ambari-server/src/main/resources/properties.json 4fee882
ambari-server/src/main/resources/scripts/stack_advisor.py 60f87f9
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 853a732
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py c9ded5e
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml d562246
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py b8ddc49
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py cf35e47
ambari-server/src/main/resources/stacks/PHD/3.0.0.0/services/stack_advisor.py 9052509
ambari-server/src/main/resources/stacks/stack_advisor.py 42db088
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8f7c199
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java 87729b1
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java 3f21bce
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py bae5ef8
ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 11356a2
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 5fbc945
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml de723a3
Diff: https://reviews.apache.org/r/32488/diff/
Testing
-------
mvn clean test
Thanks,
Dmytro Sen