You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/18 10:34:34 UTC
[GitHub] [incubator-nuttx-apps] jerpelea opened a new pull request, #1357: apps: system: add libjpeg
jerpelea opened a new pull request, #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357
## Summary
This package contains C software to implement JPEG image encoding, decoding, and transcoding. JPEG is a standardized compression method for full-color and grayscale images.
The distributed programs provide conversion between JPEG JFIF format and image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats. The core compression and decompression library can easily be reused in other programs, such as image viewers. The package is highly portable C code; we have tested it on many machines ranging from PCs to Crays.
## Impact
JPEG support
## Testing
Spresense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998108764
##########
graphics/libjpeg/Kconfig:
##########
@@ -0,0 +1,34 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config LIBJPEG
+ bool "libjpeg"
+ default n
+ ---help---
+ Enable libjpeg.
+ This package contains C software to implement JPEG image encoding, decoding,
+ and transcoding. JPEG is a standardized compression method for full-color
+ and grayscale images.
+ The distributed programs provide conversion between JPEG JFIF format and
+ image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats. The
+ core compression and decompression library can easily be reused in other
+ programs, such as image viewers. The package is highly portable C code;
+ we have tested it on many machines ranging from PCs to Crays.
+ libjpeg is provided from http://www.ijg.org/
+
+if LIBJPEG
+
+config LIBJPEG_VER
+ string "libjpeg version"
+ default "9c"
+
+config LIBJPEG_TEMP_DIR
Review Comment:
why not use LIBC_TMPDIR directly
##########
graphics/libjpeg/Make.defs:
##########
@@ -0,0 +1,26 @@
+############################################################################
+# apps/graphics/libjpeg/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_LIBJPEG),y)
Review Comment:
```suggestion
ifneq ($(CONFIG_LIBJPEG),)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998151454
##########
graphics/libjpeg/Kconfig:
##########
@@ -0,0 +1,34 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config LIBJPEG
+ bool "libjpeg"
+ default n
+ ---help---
+ Enable libjpeg.
+ This package contains C software to implement JPEG image encoding, decoding,
+ and transcoding. JPEG is a standardized compression method for full-color
+ and grayscale images.
+ The distributed programs provide conversion between JPEG JFIF format and
+ image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats. The
+ core compression and decompression library can easily be reused in other
+ programs, such as image viewers. The package is highly portable C code;
+ we have tested it on many machines ranging from PCs to Crays.
+ libjpeg is provided from http://www.ijg.org/
+
+if LIBJPEG
+
+config LIBJPEG_VER
+ string "libjpeg version"
+ default "9c"
+
+config LIBJPEG_TEMP_DIR
Review Comment:
if so, the default value should align with LIBC_TMPDIR, otherwise, it just make the integration more trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998036332
##########
system/libjpeg/Makefile:
##########
@@ -0,0 +1,74 @@
+############################################################################
+# apps/system/libjpeg/Makefile
Review Comment:
ditto
##########
system/libjpeg/Kconfig:
##########
@@ -0,0 +1,34 @@
+#
Review Comment:
should we move to apps/graphics like tiff?
##########
system/libjpeg/Make.defs:
##########
@@ -0,0 +1,26 @@
+############################################################################
+# apps/mlearning/darknet/Make.defs
Review Comment:
correct the path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998142029
##########
graphics/libjpeg/Kconfig:
##########
@@ -0,0 +1,34 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config LIBJPEG
+ bool "libjpeg"
+ default n
+ ---help---
+ Enable libjpeg.
+ This package contains C software to implement JPEG image encoding, decoding,
+ and transcoding. JPEG is a standardized compression method for full-color
+ and grayscale images.
+ The distributed programs provide conversion between JPEG JFIF format and
+ image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats. The
+ core compression and decompression library can easily be reused in other
+ programs, such as image viewers. The package is highly portable C code;
+ we have tested it on many machines ranging from PCs to Crays.
+ libjpeg is provided from http://www.ijg.org/
+
+if LIBJPEG
+
+config LIBJPEG_VER
+ string "libjpeg version"
+ default "9c"
+
+config LIBJPEG_TEMP_DIR
Review Comment:
please use the provided config option for easy integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998142875
##########
graphics/libjpeg/Make.defs:
##########
@@ -0,0 +1,26 @@
+############################################################################
+# apps/graphics/libjpeg/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_LIBJPEG),y)
Review Comment:
they are similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998151454
##########
graphics/libjpeg/Kconfig:
##########
@@ -0,0 +1,34 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config LIBJPEG
+ bool "libjpeg"
+ default n
+ ---help---
+ Enable libjpeg.
+ This package contains C software to implement JPEG image encoding, decoding,
+ and transcoding. JPEG is a standardized compression method for full-color
+ and grayscale images.
+ The distributed programs provide conversion between JPEG JFIF format and
+ image files in PBMPLUS PPM/PGM, GIF, BMP, and Targa file formats. The
+ core compression and decompression library can easily be reused in other
+ programs, such as image viewers. The package is highly portable C code;
+ we have tested it on many machines ranging from PCs to Crays.
+ libjpeg is provided from http://www.ijg.org/
+
+if LIBJPEG
+
+config LIBJPEG_VER
+ string "libjpeg version"
+ default "9c"
+
+config LIBJPEG_TEMP_DIR
Review Comment:
if so, the default value should align with LIBC_TMPDIR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998150641
##########
graphics/libjpeg/Make.defs:
##########
@@ -0,0 +1,26 @@
+############################################################################
+# apps/graphics/libjpeg/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+ifeq ($(CONFIG_LIBJPEG),y)
Review Comment:
yes, but keep consistent with other https://github.com/apache/incubator-nuttx-apps/pull/1352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998614689
##########
graphics/libjpeg/Makefile:
##########
@@ -0,0 +1,74 @@
+############################################################################
+# apps/graphics/libjpeg/Makefile
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(APPDIR)/Make.defs
+
+SRC = libjpeg
+
+CSRCS += $(SRC)/jaricom.c
+CSRCS += $(SRC)/jcomapi.c
+CSRCS += $(SRC)/jdapimin.c
+CSRCS += $(SRC)/jdapistd.c
+CSRCS += $(SRC)/jdarith.c
+CSRCS += $(SRC)/jdatasrc.c
+CSRCS += $(SRC)/jdcoefct.c
+CSRCS += $(SRC)/jdcolor.c
+CSRCS += $(SRC)/jddctmgr.c
+CSRCS += $(SRC)/jdhuff.c
+CSRCS += $(SRC)/jdinput.c
+CSRCS += $(SRC)/jdmainct.c
+CSRCS += $(SRC)/jdmarker.c
+CSRCS += $(SRC)/jdmaster.c
+CSRCS += $(SRC)/jdmerge.c
+CSRCS += $(SRC)/jdpostct.c
+CSRCS += $(SRC)/jdsample.c
+CSRCS += $(SRC)/jdtrans.c
+CSRCS += $(SRC)/jerror.c
+CSRCS += $(SRC)/jidctflt.c
+CSRCS += $(SRC)/jidctfst.c
+CSRCS += $(SRC)/jidctint.c
+CSRCS += $(SRC)/jquant1.c
+CSRCS += $(SRC)/jquant2.c
+CSRCS += $(SRC)/jutils.c
+CSRCS += $(SRC)/jmemmgr.c
+CSRCS += $(SRC)/jmemname.c
+
+CFLAGS += -DTEMP_DIRECTORY=\"$(CONFIG_EXTERNALS_LIBJPEG_TEMP_DIR)\"
+
+CFLAGS += -Wno-shadow -Wno-strict-prototypes -Wno-unknown-pragmas
+
+MODULE = $(CONFIG_LIBJPEG)
+
+libjpeg.tar.gz:
+ $(Q) curl -L http://www.ijg.org/files/jpegsrc.v$(CONFIG_LIBJPEG_VER).tar.gz -o libjpeg.tar.gz
+ $(Q) tar xf libjpeg.tar.gz
+ $(Q) mv jpeg-$(CONFIG_LIBJPEG_VER) libjpeg
+ $(Q) patch -Np1 <0001-libjpeg-add-preconfigured-jconfig.h.patch
Review Comment:
```suggestion
$(Q) patch -Np1 < 0001-libjpeg-add-preconfigured-jconfig.h.patch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1357: apps: system: add libjpeg
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1357:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org