You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/09 13:03:30 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4777: Load modules to support NAT traversal in VR
ravening opened a new pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777
### Description
Load necessary modules so that VPN connection works properly
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804752834
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804708257
@Pearl1594 can you include this in the 4.15.1 and cks/master PRs for new systemvmtemplates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-801862024
@rhtyd can we incorporate this in the new systemvm template?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#discussion_r590524485
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -93,6 +93,7 @@ start() {
sync
/opt/cloud/bin/setup/bootstrap.sh
+ modprobe nf_nat_pptp
Review comment:
limitation of warranty: needs testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#discussion_r590424670
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -93,6 +93,7 @@ start() {
sync
/opt/cloud/bin/setup/bootstrap.sh
+ modprobe nf_nat_pptp
Review comment:
@DaanHoogland it requires rebuild of systemvm template I guess ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#discussion_r590524125
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -93,6 +93,7 @@ start() {
sync
/opt/cloud/bin/setup/bootstrap.sh
+ modprobe nf_nat_pptp
Review comment:
yes, the other file, tools/appliance/systemvmtemplate/scripts/configure_conntrack.sh
So if we have a systemvm rebuild we can remove this again? It will be part of the systemvm.iso and the other bit should allready have loaded it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804740019
> @ravening if this is useful/needed in 4.15.1, can you change the base branch and milestone?
@rhtyd rebased it to 4.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804753559
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-801979705
> @rhtyd shouldn't we _only_ include the changes in https://github.com/apache/cloudstack/pull/4777/files#diff-c1dd33dcef66362966d2f8b3598d6b2412c49a048b89c75c02486c5c3d58e351 and not the explicit modprobe? It seems redundant to have both.
modprobe works with existing template and previous releases.
it is not required if we build new systemvm template
anyway, they are not harmful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-801866812
The scripts run on systemvm start by calling modprobe, no need to change/include in the template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804789165
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-801867970
@ravening if this is useful/needed in 4.15.1, can you change the base branch and milestone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd removed a comment on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804752834
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-801946424
@rhtyd shouldn't we *only* include the changes in https://github.com/apache/cloudstack/pull/4777/files#diff-c1dd33dcef66362966d2f8b3598d6b2412c49a048b89c75c02486c5c3d58e351 and not the explicit modprobe? It seems redundant to have both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804767213
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804788603
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-805238669
<b>Trillian test result (tid-223)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35441 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4777-t223-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 81.56 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.14 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#issuecomment-804784131
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#discussion_r599351188
##########
File path: tools/appliance/systemvmtemplate/scripts/configure_conntrack.sh
##########
@@ -42,6 +42,7 @@ nf_conntrack_pptp
nf_conntrack_proto_gre
nf_nat_tftp
nf_nat_ftp
+nf_nat_pptp
Review comment:
We dont' need this, as we can call in the router/vpc router shell scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4777: Load modules to support NAT traversal in VR
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4777:
URL: https://github.com/apache/cloudstack/pull/4777#discussion_r590400878
##########
File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
##########
@@ -93,6 +93,7 @@ start() {
sync
/opt/cloud/bin/setup/bootstrap.sh
+ modprobe nf_nat_pptp
Review comment:
why must this one be explicitely be loaded while the other nat and conntrack modules are 'just' written to /etc/modules?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org