You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2021/11/16 23:27:34 UTC
Review Request 73713: RANGER-3468: When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox Logout page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73713/
-----------------------------------------------------------
Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3468
https://issues.apache.org/jira/browse/RANGER-3468
Repository: ranger
Description
-------
Fixed an issue where inactivity timeout request is not handled properly when the requested sessionid is invalid. Also added Content-Type header with value as application/x-http-headers in the logout redirect response
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c0ff06ea9
Diff: https://reviews.apache.org/r/73713/diff/1/
Testing
-------
Patched and verified few tests for regressions.
Thanks,
Sailaja Polavarapu
Re: Review Request 73713: RANGER-3468: When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox Logout page
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73713/
-----------------------------------------------------------
(Updated Dec. 1, 2021, 10:34 p.m.)
Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3468
https://issues.apache.org/jira/browse/RANGER-3468
Repository: ranger
Description
-------
Fixed an issue where inactivity timeout request is not handled properly when the requested sessionid is invalid. Also added Content-Type header with value as application/x-http-headers in the logout redirect response
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c0ff06ea9
Diff: https://reviews.apache.org/r/73713/diff/2/
Changes: https://reviews.apache.org/r/73713/diff/1-2/
Testing
-------
Patched and verified few tests for regressions.
Thanks,
Sailaja Polavarapu
Re: Review Request 73713: RANGER-3468: When multiple Ranger tabs are opened, Some tabs are not redirecting to Knox Logout page
Posted by Kishor Gollapalliwar <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73713/#review223766
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java
Line 400 (original), 410 (patched)
<https://reviews.apache.org/r/73713/#comment312852>
Please consider removing extra tab/ space at line #410 & #411
- Kishor Gollapalliwar
On Nov. 16, 2021, 11:27 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73713/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2021, 11:27 p.m.)
>
>
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3468
> https://issues.apache.org/jira/browse/RANGER-3468
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed an issue where inactivity timeout request is not handled properly when the requested sessionid is invalid. Also added Content-Type header with value as application/x-http-headers in the logout redirect response
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerKRBAuthenticationFilter.java c0ff06ea9
>
>
> Diff: https://reviews.apache.org/r/73713/diff/1/
>
>
> Testing
> -------
>
> Patched and verified few tests for regressions.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>