You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/11/15 17:34:46 UTC

[GitHub] [helix] xyuanlu commented on a change in pull request #1902: Split BatchGetInstancesStoppableChecks

xyuanlu commented on a change in pull request #1902:
URL: https://github.com/apache/helix/pull/1902#discussion_r749543588



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceServiceImpl.java
##########
@@ -318,6 +330,9 @@ private StoppableCheck performCustomInstanceCheck(String clusterId, String insta
 
   private Map<String, String> getCustomPayLoads(String jsonContent) throws IOException {
     Map<String, String> result = new HashMap<>();
+    if (jsonContent == null) {
+      return result;
+    }

Review comment:
       I created another PR that fixes the input issue for stoppable API that depends on this refactor PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org