You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/02/01 13:15:10 UTC
[GitHub] [servicecomb-service-center] DFSOrange opened a new pull request #842: [SCB-2094] move role_test to datasource
DFSOrange opened a new pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] DFSOrange commented on a change in pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
DFSOrange commented on a change in pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842#discussion_r568259843
##########
File path: datasource/datasource_test.go
##########
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource_test
+
+import _ "github.com/apache/servicecomb-service-center/test"
Review comment:
发现有些接口mongo实现的时候是独立写的ut，和etcd的ut不一致，造成合一后跑不过，已在pr中标明，因此当前datasource下的ut和datasouce/etcd，datasource/mongo都要继续跑，后面合一之后我统一提个pr改掉这种方式
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] DFSOrange commented on a change in pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
DFSOrange commented on a change in pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842#discussion_r568259843
##########
File path: datasource/datasource_test.go
##########
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource_test
+
+import _ "github.com/apache/servicecomb-service-center/test"
Review comment:
发现有些接口mongo实现的时候是独立写的ut，和etcd的ut不一致，造成合一后跑不过，已在pr中标明，因此当前datasource下的ut和datasouce/etcd，datasource/mongo都要继续跑，后面合一之后我统一提个pr改掉这种方式
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842#discussion_r568250057
##########
File path: datasource/datasource_test.go
##########
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource_test
+
+import _ "github.com/apache/servicecomb-service-center/test"
Review comment:
如果一定要这么搞，那么就在这个目录下写好维护说明，怎么运行测试
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842#discussion_r568250057
##########
File path: datasource/datasource_test.go
##########
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource_test
+
+import _ "github.com/apache/servicecomb-service-center/test"
Review comment:
如果一定要这么搞，那么就在这个目录下写好维护说明，怎么运行测试
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang merged pull request #842: [SCB-2094] move role_test to datasource
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #842:
URL: https://github.com/apache/servicecomb-service-center/pull/842
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org