You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/05/08 17:02:20 UTC

[jira] Created: (HARMONY-448) make/build-java.xml copy-resources target copies too much

make/build-java.xml copy-resources target copies too much
---------------------------------------------------------

         Key: HARMONY-448
         URL: http://issues.apache.org/jira/browse/HARMONY-448
     Project: Harmony
        Type: Improvement

  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Trivial
 Attachments: remove.redundant.copying.diff

The make/build-java.xml copy-resources target copies:

1) org/apache/harmony/luni/internal/net/www/types.properties
2) org/apache/harmony/luni/util/ExternalMessages.properties
3) java/util/logging/logging.properties
4) 200+ files from security ... mostly test resources like serialization *.dat files

Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.

Therefore I think only 1 and 2 are really required.

I'll submit a patch to fix this shortly.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-448) make/build-java.xml copy-resources target copies too much

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-448?page=all ]
     
Mikhail Loenko closed HARMONY-448:
----------------------------------


verified by Mark

> make/build-java.xml copy-resources target copies too much
> ---------------------------------------------------------
>
>          Key: HARMONY-448
>          URL: http://issues.apache.org/jira/browse/HARMONY-448
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: remove.redundant.copying.diff
>
> The make/build-java.xml copy-resources target copies:
> 1) org/apache/harmony/luni/internal/net/www/types.properties
> 2) org/apache/harmony/luni/util/ExternalMessages.properties
> 3) java/util/logging/logging.properties
> 4) 200+ files from security ... mostly test resources like serialization *.dat files
> Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.
> Therefore I think only 1 and 2 are really required.
> I'll submit a patch to fix this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-448) make/build-java.xml copy-resources target copies too much

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-448?page=all ]

Mark Hindess updated HARMONY-448:
---------------------------------

    Attachment: remove.redundant.copying.diff

Patch to only copy the files we really need to copy in to build (and subsequently into a jar).


> make/build-java.xml copy-resources target copies too much
> ---------------------------------------------------------
>
>          Key: HARMONY-448
>          URL: http://issues.apache.org/jira/browse/HARMONY-448
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Trivial
>  Attachments: remove.redundant.copying.diff
>
> The make/build-java.xml copy-resources target copies:
> 1) org/apache/harmony/luni/internal/net/www/types.properties
> 2) org/apache/harmony/luni/util/ExternalMessages.properties
> 3) java/util/logging/logging.properties
> 4) 200+ files from security ... mostly test resources like serialization *.dat files
> Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.
> Therefore I think only 1 and 2 are really required.
> I'll submit a patch to fix this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-448) make/build-java.xml copy-resources target copies too much

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-448?page=all ]

Mikhail Loenko reassigned HARMONY-448:
--------------------------------------

    Assign To: Mikhail Loenko

> make/build-java.xml copy-resources target copies too much
> ---------------------------------------------------------
>
>          Key: HARMONY-448
>          URL: http://issues.apache.org/jira/browse/HARMONY-448
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: remove.redundant.copying.diff
>
> The make/build-java.xml copy-resources target copies:
> 1) org/apache/harmony/luni/internal/net/www/types.properties
> 2) org/apache/harmony/luni/util/ExternalMessages.properties
> 3) java/util/logging/logging.properties
> 4) 200+ files from security ... mostly test resources like serialization *.dat files
> Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.
> Therefore I think only 1 and 2 are really required.
> I'll submit a patch to fix this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-448) make/build-java.xml copy-resources target copies too much

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-448?page=all ]
     
Mikhail Loenko resolved HARMONY-448:
------------------------------------

    Resolution: Fixed

fixed in revision 409569
Mark, please verify that it works as expected

> make/build-java.xml copy-resources target copies too much
> ---------------------------------------------------------
>
>          Key: HARMONY-448
>          URL: http://issues.apache.org/jira/browse/HARMONY-448
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: remove.redundant.copying.diff
>
> The make/build-java.xml copy-resources target copies:
> 1) org/apache/harmony/luni/internal/net/www/types.properties
> 2) org/apache/harmony/luni/util/ExternalMessages.properties
> 3) java/util/logging/logging.properties
> 4) 200+ files from security ... mostly test resources like serialization *.dat files
> Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.
> Therefore I think only 1 and 2 are really required.
> I'll submit a patch to fix this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-448) make/build-java.xml copy-resources target copies too much

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-448?page=comments#action_12413479 ] 

Mark Hindess commented on HARMONY-448:
--------------------------------------

Looks good.  Thanks Mikhail.

> make/build-java.xml copy-resources target copies too much
> ---------------------------------------------------------
>
>          Key: HARMONY-448
>          URL: http://issues.apache.org/jira/browse/HARMONY-448
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Mikhail Loenko
>     Priority: Trivial
>  Attachments: remove.redundant.copying.diff
>
> The make/build-java.xml copy-resources target copies:
> 1) org/apache/harmony/luni/internal/net/www/types.properties
> 2) org/apache/harmony/luni/util/ExternalMessages.properties
> 3) java/util/logging/logging.properties
> 4) 200+ files from security ... mostly test resources like serialization *.dat files
> Clearly 4 is not really necessary.  3) might be but this file is also copied in to deploy/jre/lib which makes it possible for users to modify it.
> Therefore I think only 1 and 2 are really required.
> I'll submit a patch to fix this shortly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira