You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/07 02:39:36 UTC
[GitHub] [iceberg] dmgcodevil commented on a diff in pull request #3337: Fixed issue #3336: Best efforts to release hive table lock
dmgcodevil commented on code in PR #3337:
URL: https://github.com/apache/iceberg/pull/3337#discussion_r1041693116
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -499,11 +499,21 @@ private void unlock(Optional<Long> lockId) {
}
@VisibleForTesting
- void doUnlock(long lockId) throws TException, InterruptedException {
- metaClients.run(client -> {
- client.unlock(lockId);
- return null;
- });
+ void doUnlock(long lockId) throws TException {
+ boolean released = false;
+ while (!released) {
+ try {
+ released = metaClients.run(client -> {
Review Comment:
no, since it will be rethrown at line 514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org