You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/22 19:57:35 UTC
[jira] [Created] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Harsh J created MAPREDUCE-4185:
----------------------------------
Summary: Clean up yarn-server-nodemanager
Key: MAPREDUCE-4185
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: build
Affects Versions: trunk
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4185:
-------------------------------
Status: Patch Available (was: Open)
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4185:
-------------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.
Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4185:
-------------------------------
Attachment: 0013-YARN-Server-NodeManager-Cleanup.patch
Re-uploading a ditto patch as it looks like the QA bot didn't pick it up yet.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4185) Clean up
yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259479#comment-13259479 ]
Harsh J commented on MAPREDUCE-4185:
------------------------------------
These specific failures listed above aren't related to this patch.
Individually, all of them save for TestContainerManagerSecurity (MAPREDUCE-4189) pass for me locally.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4185) Clean up
yarn-server-nodemanager
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259473#comment-13259473 ]
Hadoop QA commented on MAPREDUCE-4185:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523767/0013-YARN-Server-NodeManager-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
org.apache.hadoop.mapred.TestClientRedirect
org.apache.hadoop.mapreduce.security.TestJHSSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2293//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2293//console
This message is automatically generated.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4185:
-------------------------------
Attachment: 0013-YARN-Server-NodeManager-Cleanup.patch
Two tests seem relevant to the change:
org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
This passes for me locally. I'm unsure what caused this - from logs it doesn't appear to be very apparent. Perhaps it was transient. Will continue to run and observe.
TestDeletionService
This had a casting bug in my change. Cast should've been to (Path[]) instead of (Path). Should be fixed in this new patch.
Other failures are intermittent and aren't related to this patch.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4185) Clean up yarn-server-nodemanager
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4185:
-------------------------------
Attachment: 0013-YARN-Server-NodeManager-Cleanup.patch
Javac warning cleanup patch for the hadoop-yarn-server-nodemanager project.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4185) Clean up
yarn-server-nodemanager
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259397#comment-13259397 ]
Hadoop QA commented on MAPREDUCE-4185:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523749/0013-YARN-Server-NodeManager-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.nodemanager.TestDeletionService
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
org.apache.hadoop.mapred.TestClientRedirect
org.apache.hadoop.mapreduce.TestMapReduceLazyOutput
org.apache.hadoop.mapreduce.security.TestJHSSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2290//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2290//console
This message is automatically generated.
> Clean up yarn-server-nodemanager
> --------------------------------
>
> Key: MAPREDUCE-4185
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4185
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0013-YARN-Server-NodeManager-Cleanup.patch, 0013-YARN-Server-NodeManager-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-yarn-server-nodemanager module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira