You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/11/13 15:00:59 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
adoroszlai opened a new pull request #1588:
URL: https://github.com/apache/ozone/pull/1588
## What changes were proposed in this pull request?
Save Ozone binaries from `compile` check, and use these in `acceptance` and `kubernetes` checks, instead of each check performing its own full build. Total execution time is similar, but the dependent checks are started later, so we save GitHub Actions cycles.
https://issues.apache.org/jira/browse/HDDS-4461
## How was this patch tested?
Tested in fork:
```
Artifact ozone-bin has been successfully uploaded!
```
https://github.com/adoroszlai/hadoop-ozone/runs/1395732068#step:8:52
```
Artifact ozone-bin was downloaded to /home/runner/work/hadoop-ozone/hadoop-ozone
```
https://github.com/adoroszlai/hadoop-ozone/runs/1395772736#step:4:11
Also verified coverage is the same (79%) as with the previous commit (760c1e8f9ecc5daa5cd49c95ca946a415976088e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-732191890
> With this modification we not only share the artifact between jobs but also archive them for 90 days.
Good point. Updated to keep it only for one day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-727908895
Great idea @adoroszlai, thanks the patch.
What do you think about using `-Pdist` instead of the custom tar execution (`-Pdist` supposed to create the tar file).
With this approach we will test exactly the same tar file which will be released...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek merged pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
elek merged pull request #1588:
URL: https://github.com/apache/ozone/pull/1588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-732166927
Thanks the update @adoroszlai
I am thinking about one thing, but I couldn't find any answer:
Isn't it a problem to store ~300M after EACH of the builds (including PR check). I couldn't find any official information about the available storage quota (there could be a limit: https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-billing-and-payments-on-github/viewing-your-github-actions-usage).
With this modification we not only share the artifact between jobs but also archive them for 90 days. Which can be hundred of gigabytes or even more.
But I am not sure if it's a problem or not.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-735821877
Thanks @elek for reviewing and committing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-735802713
> Good point. Updated to keep it only for one day.
TIL it's possible to define retention per upload. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai edited a comment on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
adoroszlai edited a comment on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-728329442
> What do you think about using `-Pdist` instead of the custom tar execution (`-Pdist` supposed to create the tar file).
>
> With this approach we will test exactly the same tar file which will be released...
@elek Testing part of the release process is a good idea, thanks. Updated the patch with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #1588: HDDS-4461. Reuse compiled binaries in acceptance test
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1588:
URL: https://github.com/apache/ozone/pull/1588#issuecomment-728329442
> What do you think about using `-Pdist` instead of the custom tar execution (`-Pdist` supposed to create the tar file).
>
> With this approach we will test exactly the same tar file which will be released...
Testing part of the release process is a good idea, thanks. Updated the patch with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org