[jira] [Commented] (OOZIE-2661) Coordinator Action status not updated when workflow job SUSPENDED

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459376#comment-15459376 ] 

Hadoop QA commented on OOZIE-2661:
----------------------------------

Testing JIRA OOZIE-2661

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1800
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

.      testMessage_withMixedStatus(org.apache.oozie.command.coord.TestAbandonedCoordChecker)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3260/

> Coordinator Action status not updated when workflow job SUSPENDED
> -----------------------------------------------------------------
>
>                 Key: OOZIE-2661
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2661
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Satish Subhashrao Saley
>            Assignee: Satish Subhashrao Saley
>            Priority: Minor
>         Attachments: OOZIE-2661-1.patch
>
>
> It's a bug in Oozie. CoordActionCheckXCommand doesn't take care of SUSPENDED state. It only handles SUCCEEDED, FAILED and KILLED.
> {code}
> protected Void execute() throws CommandException {
>         try {
>             InstrumentUtils.incrJobCounter(getName(), 1, getInstrumentation());
>             Status slaStatus = null;
>             CoordinatorAction.Status initialStatus = coordAction.getStatus();
>             if (workflowJob.getStatus() == WorkflowJob.Status.SUCCEEDED) {
>                 coordAction.setStatus(CoordinatorAction.Status.SUCCEEDED);
>                 // set pending to false as the status is SUCCEEDED
>                 coordAction.setPending(0);
>                 slaStatus = Status.SUCCEEDED;
>             }
>             else {
>                 if (workflowJob.getStatus() == WorkflowJob.Status.FAILED) {
>                     coordAction.setStatus(CoordinatorAction.Status.FAILED);
>                     slaStatus = Status.FAILED;
>                     // set pending to false as the status is FAILED
>                     coordAction.setPending(0);
>                 }
>                 else {
>                     if (workflowJob.getStatus() == WorkflowJob.Status.KILLED) {
>                         coordAction.setStatus(CoordinatorAction.Status.KILLED);
>                         slaStatus = Status.KILLED;
>                         // set pending to false as the status is KILLED
>                         coordAction.setPending(0);
>                     }
>                     else {
>                         LOG.warn("Unexpected workflow " + workflowJob.getId() + " STATUS " + workflowJob.getStatus());
>                         coordAction.setLastModifiedTime(new Date());
>                         CoordActionQueryExecutor.getInstance().executeUpdate(
>                                 CoordActionQueryExecutor.CoordActionQuery.UPDATE_COORD_ACTION_FOR_MODIFIED_DATE,
>                                 coordAction);
>                         return null;
>                     }
>                 }
>             }
> {code}
> Thank you [~puru] for pointing it out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)